Closed (fixed)
Project:
FeedAPI
Version:
6.x-1.x-dev
Component:
Code feedapi (core module)
Priority:
Normal
Category:
Task
Assigned:
Reporter:
Created:
15 Sep 2009 at 15:24 UTC
Updated:
2 Oct 2009 at 14:10 UTC
On install feedapi_node can throw an "error" if a there isn't a parser for the node type it creates. If using Aegir this error will prevent the site from installing. If we can change this to a "warning" things go just fine.
| Comment | File | Size | Author |
|---|---|---|---|
| warning_not_error.patch | 1.26 KB | jmiccolis |
Comments
Comment #1
alex_b commentedThis patch causes this test to fail:
"The feed with immediate refresh setting was refreshed. feedapi_cron.test line 44
Part of "FeedAPI Cron scheduling" tests.
Can't see at a glance why though. The scheduling tests don't seem like they have anything to do with this portion of the code. Aron?
Comment #2
aron novakalex_b: #519276: Possibly unexpected behavior because of next_refresh_time - this is the reason, i'm sure
This patch is fine.
Comment #3
aron novakJust a second: for me it sounds like that Aegir will only fail if the install profile is buggy.
There was a bug in the openatrium install profile, but i think it really, really misleading to allow to create a feedapi content-type without a valid parser.
Comment #4
jmiccolis commentedAron the issue is that on install feedapi_node creates a content type (see _feedapi_node_install_type_create()) regardless of how plan on using the feedapi_node module. IMHO feedapi_node should not create a feed node type, but it does currently. Short of removing that code we can change the error message to a warning as it's completely reasonable that people may never use this auto-generated content type.
Comment #5
aron novakcommitted