JeremyFrench [JeremyFrench]

It's hard to test this given the reliance on an external service, but I did a visual inspection of the code. I found a handful of things to tweak before this module is released. Specifically there are several calls to drupal_set_message which are not translatable and/or may contain security issues (lines 87, 170 and 315).

So, leaving "needs review" though I'm +1 on the application I'm hesitant about these important changes that need to happen (they could happen after the application is approved).

Security issues need to be resolved before the CVS account gets approved; also the use of translatable strings is an important point, in a Drupal module.

I am changing the status basing on the previous comment.

What reported by greggles about code security is still true (at least for one of the three cases).

1.   $batch = array(
         'title' => t('Batch Tagging articles.'),
         'init_message' => t('Getting Articles to tag'),
         'error_message' => t('Tagging Failed'),
         'progress_message' => '',
         'operations' => array(
           array('_inform_batch_process', array($max_days, $max_batch)), 
         ),
         'finished' => '_inform_batch_finish',
       );
       batch_set($batch);
   }
   

   Strings used in Drupal user interface have the first word written in capital case, while the others are written in lower case characters.

2. See the Drupal coding standards to understand how a module code should be written.

That seems like a nitpick below what a cvs application review should include. There are thousands of instances of improper capitalization in contrib and more created every day - I think the application should be approved at this point and further issues moved to the issue queue of the module.

Basing on the greggles's comment, I am approving JeremyFrench's application (I should have done it already).

A note about my reference to the coding standards: the coding standards report also that a module should use the Drupal Unicode functions instead on PHP string functions; when I make a reference to Drupal coding standards, it could be the code is not using such functions.

We don't change the status to closed; that is automatically done after 14 days.