thanks for this module, more patches coming. attached patch is just a simple code cleanup, no functional changes - some whitespace changes, renamed some functions that weren't namespaced with 'linode_', etc.

Zivtech uses linodes all over the place, we'll be putting some developer time into it.

CommentFileSizeAuthor
#6 cleanup.patch8.32 KBAnonymous (not verified)
#3 cleanup.patch7.79 KBAnonymous (not verified)
cleanup.patch6.23 KBAnonymous (not verified)

Comments

Anonymous’s picture

Status: Active » Needs review

woops, wrong status.

litwol’s picture

Status: Needs review » Needs work
litwol@localhost:/var/www/linode/sites/all/modules/linode$ patch -p0 < cleanup_2.patch 
patching file linode.admin.inc
Hunk #6 FAILED at 74.
Hunk #7 succeeded at 121 with fuzz 1 (offset 26 lines).
Hunk #8 succeeded at 144 (offset 26 lines).
Hunk #9 succeeded at 173 (offset 26 lines).
Hunk #10 succeeded at 186 (offset 26 lines).
1 out of 10 hunks FAILED -- saving rejects to file linode.admin.inc.rej
patching file linode.module

Anonymous’s picture

StatusFileSize
new7.79 KB

updated patch against HEAD.

Anonymous’s picture

Status: Needs work » Needs review

arg!

litwol’s picture

Status: Needs review » Needs work

Same fails. Please make a patch against DRUPAL-6--1 branch. that is where all of the development happening.

Anonymous’s picture

Status: Needs work » Needs review
StatusFileSize
new8.32 KB

3rd time lucky?

litwol’s picture

Status: Needs review » Fixed

Cheers.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.