CVS edit link for jaemmer

Hi, my name is Joel and I am a software developer for Drop Ship Access (DSA).

I have plans to create several modules and themes for drupal to allow easy integration with the DSA (http://www.dropshipaccess.com) service. (DSA sources wholesale products for resellers).

-the current theme being developed is seen here: http://drupal.dropshipaccess.com/
-the module is still being developed and will allow customers of DSA to add large amounts of products directly to their drupal/ubercart website and be able to pass sales information back to DSA for shipment.

This will allow existing customers of DSA to easily launch their own webstore for free using drupal/ubercart. This will also allow existing drupal users to be able to easily have a website with products to sell.

Thanks for your consideration.

Sincerely,
Joel

Comments

jaemmer’s picture

Title: jaemmer [jaemmer] » Attached Theme

see attached .zip for the current theme

Thanks,
Joel

jaemmer’s picture

StatusFileSize
new70.76 KB

re-posting... not sure if it was attached

avpaderno’s picture

Title: Attached Theme » jaemmer [jaemmer]
Status: Postponed (maintainer needs more info) » Needs review
Issue tags: +Theme review

Please, change only the status to needs review when you upload a new file; other fields are not thought to be used from the applicant, and they are normally left to the original value.

avpaderno’s picture

Status: Needs review » Needs work
  1. Themes, and modules should not use an underscore as first character.
  2. The file LICENSE.txt needs to be removed, as it is not possible to commit it into CVS.
  3.   t('Tags').': '
    

    It would be better to use t('Tags: ').

  4. <script type="text/javascript">
    /* <![CDATA[ */
    		$(document).ready(function(){
    			$("#right-toggle").click( function() {
            $("#right-toggle").hide();
            $("#content").width("953px");
            $("#sidebar-left").css("padding-left","775px");
            $("#right").css("float","none");
            $("#content").css("border-right","1px solid #1A4864");
            $("#content").css("border-left","1px solid #1A4864");
            $("#content").css("border-bottom","1px solid #1A4864");
            $("#content").css("margin","0");
    			});
        });
    /* ]]> */
    </script>
    

    JavaScript code should be put in an external file.

  5.  require('page.tpl.php');
    

    The path of the file is relative to the Drupal root directory; this means the file will not found, as it is inside the theme directory, which is different from the Drupal root directory.

  6. // We need jQuery included on all admin pages.
    if (arg(0) == 'admin') {
      drupal_add_js('misc/jquery.js');
    }
    

    That file is always included from Drupal; themes (as well modules) don't need to include it.

avpaderno’s picture

; $Id: _09springtime.info,v 1.0 2009/09/09 13:23:32 jaemmer Exp $
name = _09 Springtime
description = Fresh, tableless, multicolumn design for drupal sites
verion = VERSION
core = 6.x
engine = phptemplate
stylesheets[all][] = style.css
stylesheets[print][] = print.css
version = "6.13"
project = "drupal"
datestamp = "1246689729"

The lines containing verion (which should be version), version, project, and datestamp should be removed.

jaemmer’s picture

Status: Needs work » Needs review
StatusFileSize
new65.19 KB

Hi,

Thank you for reviewing my theme. I have updated the theme to address the issues mentioned.

Thanks,
Joel

avpaderno’s picture

Status: Needs review » Needs work

The short name of the theme needs to not start with a number; you could use nine_springtime.

jaemmer’s picture

Status: Needs work » Needs review
StatusFileSize
new65.39 KB

name updated, thanks

avpaderno’s picture

Status: Needs review » Needs work
name = 09 Springtime

That should be changed as well.

jaemmer’s picture

Status: Needs work » Needs review
StatusFileSize
new60.19 KB

changed name and a few minor changes. lost the year since '09 is almost over anyway.

Thanks

avpaderno’s picture

Status: Needs review » Fixed

Status: Fixed » Closed (fixed)
Issue tags: -Theme review

Automatically closed -- issue fixed for 2 weeks with no activity.

avpaderno’s picture

Component: Miscellaneous » new project application
Assigned: Unassigned » avpaderno
Issue summary: View changes
Status: Closed (fixed) » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.