bob_hirnlego [radioradicale]

1. // $Id: $
   

   The CVS ID tag should be $Id$.

2.     drupal_set_message(t("Warning: note that your account is limited because it's not yet been convalidated.<br>Please recheck your email inbox and spam folder.<br>If you didn't received the email " . l("follow this link for a new request","toboggan/revalidate/{$user->uid}")) ,'error');
   

   Rather than concatenating a string, use a placeholder; concatenated string cannot be extracted for translation, and the string would not appear in the translation template.

3. hook_init() is called only on not cached pages; depending on the case, this could cause problems.

      die;

Hook implementations should never call die().

4.     if (drupal_strlen($object->name) > 20) {
         $name = drupal_substr($object->name, 0, 15) . '...';
       }
   

   Drupal has the function truncate_utf8().

5.   global $hydra_master_name, $hydra_copy_tables, $user;
   

   Global variables used by the module should be named something like $_hydra_master_name.

6. function hydra_get_db_tables($prefix) {  
     $tables = array();
     $result = db_query("SHOW TABLES LIKE '{$prefix}_%'");
     while ($table = db_fetch_array($result)) {
       $value = array_values($table);
       $name = str_replace("{$prefix}_", '', $value[0]);
       $tables[$name] = $name;
     }  
     return $tables;
   }
   

   Isn't SHOW TABLES specific for a database engine?

7.   $hostname = hydra_get_current_hostname();
     $site = db_fetch_object(db_query("SELECT * FROM {hydra_sites} WHERE hostname = '%s' LIMIT 1", $hostname));
   

   For that, there is the function db_query_range().

8.   watchdog('hydra join', "User {$account->name} joined {$site->fullname}");
   

   Use placeholders.

9.   $nids = '('.join(',',$nids).')';
     // Prepare update values
     $set = "{$op} = {$value}";
     db_query("UPDATE {hydra_nodes} SET {$set} WHERE nid IN {$nids} AND sid = %d", $hydra_current_site->sid);
   }
   

   There is the function db_placeholders().

10.   // We check the paths registered by setting.
      $pages = variable_get('hydra_disabled_user_db_rewrite', join("\n", $paths));
      $regexp = '/^('. preg_replace(array('/(\r\n?|\n)/', '/\\\\\*/', '/(^|\|)\\\\<front\\\\>($|\|)/'), array('|', '.*', '\1'. preg_quote(variable_get('site_frontpage', 'node'), '/') .'\2'), preg_quote($pages, '/')) .')$/';
      // Compare with the internal and path alias (if any).
      $page_match = preg_match($regexp, $_GET['q']);
      if (!$page_match && function_exists('drupal_get_path_alias')) {
        $path = drupal_get_path_alias($_GET['q']);
        if ($path != $_GET['q']) {
          $page_match = preg_match($regexp, $path);
        }
      }
      if ($page_match) {
        return TRUE;
      }
    

    There is the function drupal_match_path().

11.   $default_settings = $_SERVER['DOCUMENT_ROOT'] . '/' . drupal_get_path('module', 'hydra') . '/misc/settings.php.template';
      $settings_file = "{$_SERVER['DOCUMENT_ROOT']}/sites/{$values['name']}/settings.php";
    

    base_path() is normally used in such cases.

12.     while ($table = db_result($result)) {
          db_query("DROP TABLE IF EXISTS {$table}");
        }
    

    There is the function db_drop_table(), even if it is normally used on update functions; as alternative, it is possible to execute the query only after db_table_exists() returned TRUE.

13. The file LICENSE.txt must be removed, as it is not possible to commit such file in CVS.

You can use @db_query('DROP TABLE {'. $table .'}'); that query is surely compatible with all the database engines that Drupal supports.

1. include_once("includes/hydra.inc");
   include_once("includes/hydra.api.inc");
   include_once("includes/hydra.rpc.inc");
   

   The current directory set when Drupal runs is the Drupal root directory; the paths used would not allow PHP to find the files.
   When a module needs to include code files, it should use module_load_include().

2. Drupal coding standards report when to use a space before or after an operator; the code doesn't follow that recommendation.
   The coding standars also reports which functions should be called from a module.
3. The node operations use the same label used by core node operations. Users would see two operations with the same description, and they would not know which one they are using.

4. ; dependencies[] = hydra
   

   Such lines reports the dependency from other Drupal modules, not from external code. That line is commented out, but it should be removed as it could confuse the user.

1. version = VERSION
   

   That line should be removed. The packaging script already adds a version line.

2. Drupal modules are supposed to use the Drupal Unicode functions, which correctly handle the Unicode characters (differently from substr(), and strlen() (see http://drupal.org/node/473460).

I am not sure if what you are asking is acceptable; I would open a report in the Drupal.org webmasters queue, so that somebody could say if this is acceptable or not.
This issue queue is used from a minority of Drupal webmasters, and your request would not be much visible.

Also, you already used radioradicale as CVS username; it is not possible to change CVS username, but it is possible to swap it between two different users.