CVS edit link for katiebot

Have upgraded a Drupal 5 / Ubercart 1 module (Recently Viewed Products) to Drupal 6 / Ubercart 2. The original author never added it here.

Comments

katiebot’s picture

Component: Miscellaneous » Code
Status: Postponed (maintainer needs more info) » Needs review
StatusFileSize
new2.1 KB

Thank you, I have attached the module.

avpaderno’s picture

Component: Code » Miscellaneous
Status: Needs review » Closed (won't fix)

In this case, you should open a support request in the project issue, and offer to become co-maintainer of the module; when the current maintainer accepts your offer, then you apply for a CVS account reporting the link to the issue where the maintainer replied you.

I am marking this report as won't fix.

avpaderno’s picture

Status: Closed (won't fix) » Needs review
Issue tags: +Module review

I misunderstood what the OP meant; she just meant that the module has never been published on Drupal.org; I apologize for my mistake.

avpaderno’s picture

Status: Needs review » Fixed
  1.   if (module_exists('uc_recent_products')) {
        $items['admin/settings/recentproducts'] = array(
          'title' => 'Recently Viewed Products',
          'description' => 'Administer settings for your recently viewed products block',
          'page callback' => 'drupal_get_form',
          'page arguments' => array('uc_recent_products_form'),
          'access arguments' => array('administer store'),
        );
      }
    

    This code is useless. The module is checking if it exists, but if it would not exists, then the function would be never called.

  2.     $query = db_query_range("SELECT DISTINCT nid FROM {uc_recent_products} WHERE sid = '%s' ORDER BY visit_time DESC", uc_recent_products_get_id(), $from = 0, $count = $limit);
    

    It should be better to use db_distinct_field().

katiebot’s picture

StatusFileSize
new2.1 KB

Thank you for your help! I've made the two changes, attached are the updated files.

avpaderno’s picture

Your CVS account has been already approved; you can commit your code in CVS.

Status: Fixed » Closed (fixed)
Issue tags: -Module review

Automatically closed -- issue fixed for 2 weeks with no activity.

avpaderno’s picture

Component: Miscellaneous » new project application
Assigned: Unassigned » avpaderno
Issue summary: View changes
Status: Closed (fixed) » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.