CVS edit link for psy

I have written several modules for Drupal 6.x & UberCart 2.x.

One is called UberCart Checkout Review Extras.

It can be downloaded from the Ubercart Contribution site using this url
Contrib : http://www.ubercart.org/contrib/12839
Module: http://www.ubercart.org/files/uc_review_extras_6.x_1.0_beta1.zip

The first is a payment method for Australian payment gateway called Paymate. The module name is "uc_pay_mate".

The second is a module called "Oz Commerce" that provides services to UberCart users in Australia for dealing with Australian Business Numbers (ABN) and handling Goods & Services Tax (GST). The module name is "uc_oz_commerce".

Currently there is no robust, integrated modules for handling Australian tax and reporting requirements that fit into the above version requirements.

There is no module for Paymate transactions at all.

There are several hacks around for GST handling and a modified version of the VAT Number module for handling ABNs that does not work under D6-U2. These are hardly good solutions.

My ABN-GST system provides extensive validation and checking of both customer and store ABNs, checking of billing and delivery addresses to automatically hide it self from international customers, integrates nicely with the user profiles and has a thorough administrative interface.

Both modules are beta ready and will be deployed on a couple of my sites in the near future. I believe from reading the forums at UberCart that there is a strong demand for these modules.

Future versions od Oz Commerce will support New Zealand tax regimes once I can actually understand how their strange system works.

Future versions of Paymate will support XML payment gateway processing once the company starts this as well their IPN similar notification service.

I have been developing with PHP and MySQL for some years and am currently employed at an tertiary institution in Australia.

Comments

avpaderno’s picture

The code to review must be uploaded here.

psy’s picture

StatusFileSize
new12.55 KB

Ok Then.

avpaderno’s picture

Status: Postponed (maintainer needs more info) » Needs review
Issue tags: +Module review
psy’s picture

Do i have to do something here?

avpaderno’s picture

Until the status is not changed, you don't need to do anything.

psy’s picture

Status: Needs review » Active

"Until the status is not changed, you don't need to do anything."

Does that mean I have to post a better version?

avpaderno’s picture

Status: Active » Needs review

I meant until the status is not changed from somebody who reviewed your module.
If nobody has made a review of your code that doesn't mean you need to post a better version.

psy’s picture

OK. Sorry i didn't understand the process every well.

Does this happen with every module that gets submitted?

This one is very simple and i have a few more quite complex ones nearing completion.

Cheers J

avpaderno’s picture

The process is made only for the CVS account application; once you get it, the process is not repeated for each project you make.

avpaderno’s picture

Status: Needs review » Needs work
  1.   '#default_value' => check_plain(variable_get('uc_review_extras_refunds_title', 'Refunds')),
    

    The form API already filters the values used for the form fields.

  2. $form['refunds']['uc_review_extras_refunds_text'] = array(
      '#input_format' => '1',
      '#rows' => '5',
      '#cols' => '40',
      '#weight' => '1',
      '#type' => 'textarea',
      '#title' => t('Text'),
      '#default_value' => variable_get('uc_review_extras_refunds_text', 'Refunds note here'),
    );
    

    #input_format is not an attribute normally used from Drupal; if you are trying to set the input format accepted, you should do something different.

  3.   '#summary callback' => 'summarize_checkbox',
      '#summary arguments' => array(
          t("The '@title' notice is enabled.", array('@title' => variable_get('uc_review_extras_delivery_title', ''))),
          t("The '@title' notice is disabled.", array('@title' => variable_get('uc_review_extras_delivery_title', ''))),
        ),
    

    Also this attributes are not used by Drupal.

  4. function uc_review_extras_install() {
    
      // init all the variables
      variable_set('uc_review_extras_delivery_title', 'Delivery');
      variable_set('uc_review_extras_security_title', 'Security');
      variable_set('uc_review_extras_privacy_title', 'Privacy');
      variable_set('uc_review_extras_returns_title', 'Returns');
    

    Drupal variables are not initialized during installation of a module; if you need a default value, that is the second argument passed to variable_get().

psy’s picture

StatusFileSize
new12.26 KB

Hi,

I applied the changes you suggested. New version posted.

In regards to point 3 though I would draw your attention to this post on ubercart.org by Ryan about summary callbacks extensions to FAPI. This is a usability extension for Ubercart Store Administration

http://www.ubercart.org/docs/developer/7490/form_summaries

Thanks for your time.

avpaderno’s picture

Status: Needs work » Needs review

Remember to change the status of the report, after you upload new code; differently the reviewers (who are more than one) cannot know there is something to review.

avpaderno’s picture

Status: Needs review » Fixed
  1. The file LICENSE.txt needs to be removed.
  2.     'description' => 'Edit the Review Extra Policy Statements.',
    

    Description and title doesn't use the title case; just the first word is written in capital case.

  3.   if (variable_get('uc_review_extras_enabled', TRUE) == 1) return;
    

    Even in the simpler IF-statement, the coding standards suggests to use the curly brackets; the line should be written as

      if (variable_get('uc_review_extras_enabled', TRUE) == 1) {
        return;
      }
    
psy’s picture

StatusFileSize
new6.53 KB

Hi KiamLaLuno,

thanks for all your efforts. I can see that you are very busy!

updated version posted - now onto CVS!

cheers J

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

aptereket’s picture

When new version planned to release?

avpaderno’s picture

Component: Miscellaneous » new project application
Assigned: Unassigned » avpaderno
Issue summary: View changes
Status: Closed (fixed) » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.