CVS edit link for alanburke

Hi Support,
I have written a payment gateway module for the Ubercart project, that allows sites to to integrate with Realex, a payment provider based in Ireland.
http://www.realexpayments.com/

I have it on the Ubercart site for the last little while
http://www.ubercart.org/contrib/6147
and I've just made some updates, so I'd rather put it on d.o, and is now the standard for Ubercart contrib modules.

Drupal, Ubercart and Realex are all experiencing growth in Ireland, so I'd prefer to have this code in the open.

Regards
Alan

CommentFileSizeAuthor
#5 uc_realex.tar_.gz3.65 KBalanburke
#1 uc_realex.tar_.gz3.62 KBalanburke

Comments

alanburke’s picture

StatusFileSize
new3.62 KB

Hi Support
Latest version attached.

alanburke’s picture

Status: Postponed (maintainer needs more info) » Needs review

Updating Status.

avpaderno’s picture

Issue tags: +Module review
avpaderno’s picture

Status: Needs review » Needs work
  if ($result =='00') {
    $comment = t('Paid by Realex online for order #!order, Transaction #!transid , Batch #!batchid', 
   array(
    '!order' => check_plain($orderid), 
    '!transid' => check_plain($pasref), 
    '!batchid' => check_plain($batch)
   ));

Using the right placeholder, there is no need to call check_plain().

alanburke’s picture

Status: Needs work » Needs review
StatusFileSize
new3.65 KB

Hi KiamLaLuno,
Thanks for the review.
Please find updated code attached.

avpaderno’s picture

Status: Needs review » Fixed
    $output .= uc_cart_complete_sale($order);
    $output .= '<h3>' . t('Payment Successful!') . '</h3>';
    $options = array();
    $options['absolute'] = TRUE;
    $output .= '<h2>' . l(t('Click to return to website','<front>', $options)) . '</h2>';

I guess it should be l(t('Click to return to website'),'<front>', $options).

Status: Fixed » Closed (fixed)
Issue tags: -Module review

Automatically closed -- issue fixed for 2 weeks with no activity.

avpaderno’s picture

Component: Miscellaneous » new project application
Assigned: Unassigned » avpaderno
Issue summary: View changes
Status: Closed (fixed) » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.