I already have a CCK field module written for VIN numbers that provides SAE validation on the VIN to verify it is well-formed. Further enhancements might be to actually decode the VIN and store the related info in the database (our implementation does not require this, but others might) or to provide a hook or AJAX/XML-RPC point to verify the VIN is in the list of "acceptable VINs" (in our case, one we have sold).
Additionally, we are investigating building a KB and warranty tracking system keying records to the VIN (subsequently tying them to a manufacturer, model and year) so we can generate reports on warranty issues (by VIN, percentage units by model or year, percentage cost by model or year, etc) and provide automagic grouping of issues for easy reference by our customers. We are still evaluating using the 'Case Tracker' module for this, but in the event it will not fit our model well enough, we will roll our own. Once this is complete, it would also be made available to the Drupal community if you think there might be an interest.
As for my personal credentials - I worked on enterprise-class software for Zeh Graphic Systems, BMC, and Caminus (now owned by SunGard) for 13 years, so have an appreciation for tight, secure, fast code. I've coded extensively in C/C++, PHP, Java, and worked with every mainstream database platform out there on almost every available OS platform (thanks to BMC and Zeh!). I have read the Drupal Coding Standard and related documents, and would like to contribute new modules as well as any assitance to existing modules I can lend.
Re-application note - for whatever reason, I am not receiving notification emails when the application is being processed beyond the request to upload code, and cannot seem to find a setting for notifications on my account. That is the reason my last application went dead due to failure to reply - I received no notice of updates to my application from the reviewer(s). If that notification setting is buried somewhere, PLEASE point me in the right direction so I don't lose touch with the review process again!
| Comment | File | Size | Author |
|---|---|---|---|
| #7 | vinfield-6.x-1.x-dev.tar_.gz | 3.19 KB | arpieb |
| #5 | vinfield-6.x-1.x-dev.tar_.gz | 3.2 KB | arpieb |
| #1 | vinfield-6.x-1.x-dev.tar_.gz | 3.21 KB | arpieb |
Comments
Comment #1
arpieb commentedHere is the first module developed for capturing vehicle identification numbers (VINs) as well as checking to make sure they are well-formed values.
-R
Comment #2
avpadernoSee the Drupal coding standards to understand how a module code should be written.
Comment #3
arpieb commentedI have reviewed the coding standards, and am not sure exactly what parts of my code you take exception to. Please advise as to what doesn't adhere, as the last reviewer had no issues other than some strings that weren't properly wrapped with the t() function call.
Thanks!
Comment #4
avpadernoI can assure you the code doesn't follow the coding standards. I don't list for which points the code doesn't follow the standards because who applies for CVS account must show he understands how to write a module code; if I would say which is the code that needs to be changed, then you would change it because I told you to do so, and not because you understood what you read.
I can only report that the discrepancies are quite evident.
Comment #5
arpieb commentedAlthough the Coding Standards say nothing about variable naming conventions under Naming Conventions, it appears the Coder module took exception to the variable naming conventions in a couple functions that I copied from a production environment.
If that is a make-or-break requirement for module coding as the Coder review turned up nothing else, maybe it should be listed in those docs I was referred to...? The only mention I saw for variable naming was under Best Practices: Naming your functions, naming your variables which only says to give your variables meaningful names.
If I've missed a relevant section of the Coding Standards that do not fall under the document tree I was referred to, please tell me where else to look. In the meantime, attached is the revised source that passed the Coder review with no warnings or errors...
Comment #6
avpadernoAvoid the concatenation of strings, when they are passed to
t(); you can use the placeholders the function supports.Comment #7
arpieb commentedOK, hopefully third try is the charm. Replaced non-UC-friendly function calls with Drupal equivalents, and have corrected the calls to t(). Thank you for the guidance on those last two bits.
According to Use Drupal unicode functions for strings the Coder module should have caught those non-UC-friendly function calls. Is that a known issue with Coder, or do you have to set a stricter setting on the code review than "normal?"
Thanks!
Comment #8
avpadernoComment #11
avpaderno