Closed (fixed)
Project:
Drupal.org CVS applications
Component:
new project application
Priority:
Normal
Category:
Task
Assigned:
Issue tags:
Reporter:
Created:
23 Aug 2009 at 04:05 UTC
Updated:
2 Oct 2019 at 13:34 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
ConnorK commentedHere is the actual module.The actual code for the module can be found in Comment #5.
Please review.
Comment #2
avpadernoComment #3
dawehnerVerry minor, but you should do 'Search:' translateable.
Thats just a comment, you don't use any lines together with the two different formIds. Why not just use two form functions for the two forms.
Then you could save hook_forms.
Comment #4
avpadernoA validate function should only validate the data, not modify it. Then, the data are filtered in output, not in input; differently, users would see
&altered in&, when they change the settings for the second time.Comment #5
ConnorK commentedAttached is the module with the above comments taken into account.
Changes
--------
1. Separated form construction, thus eliminating the hook_form() (Thanks for pointing that out dereine).
2. Made instance of string "Search:" translatable (Thanks again dereine).
3. Replaced PHP string functions with Drupal string functions when possible.
4. Dropped the portions of the validate function that were unnecessary (Thanks for pointing that out KiamLaLuno).
Comment #6
avpadernoI am not sure the relative URL would work; what should it point to (../help/adjustisearch)?
The rest is fine.
Comment #7
ConnorK commentedFixed. Re-encoded the link using url(). Will be in the final version of this release.
Comment #10
avpaderno