Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.When submitting the themes list page, a status message is shown regarding the administration theme. That message contains a link to the old admin theme page (admin/settings/admin). This should be removed as there's no separate page anymore.
| Comment | File | Size | Author |
|---|---|---|---|
| #22 | system-admin-theme-msg-556714-22.patch | 1.51 KB | cburschka |
| #12 | admin-theme.jpg | 282.38 KB | Dries |
| #4 | system-administration-theme-link-2.patch | 1.1 KB | davyvdb |
| system-administration-theme-link.patch | 1.35 KB | davyvdb | |
Comments
Comment #1
tobiasbComment #2
webchickCommitted to HEAD! Thanks!
Comment #3
Pasquallethe whole message should be removed as it has no meaning
1. the admin theme setting is on this same page
2. "the administration theme is still set to" this is wrong because the admin theme can be changed on this page
Comment #4
davyvdb CreditAttribution: davyvdb commentedCouldn't be more true. I always looked over the message itself.
Comment #5
PasqualleComment #7
davyvdb CreditAttribution: davyvdb commentedPatch still ok. Bot is just failing.
Comment #8
drewish CreditAttribution: drewish commentedYeah the patch is still fine. Just manually checked it.
Comment #9
webchickHm. I'm not sure about this. It is very confusing when you select a new theme and get back.... the same theme you had before. Particularly when Drupal 7 is going to ship with an admin theme enabled by default. I know I've been confused by this myself on sites a couple of times since I normally don't use an admin theme, and the message has helped me. I'd prefer to fix the message rather than remove it.
Is the only problem the use of the word "still", or..?
Comment #10
PasqualleI think this page does not need this message. If the setting is confusing then a help text (or better form field description) would be more appropriate..
Comment #11
davyvdb CreditAttribution: davyvdb commentedThe latest patch removes this message.
Comment #12
Dries CreditAttribution: Dries commentedIt sounds like this could be clarified with a better UI. Maybe there should be a radio-button in the main table to select the admin theme? See screenshot for additional details.
Comment #13
Pasqualleit was discussed here: #135976: Make picking administration theme more user-friendly
Comment #14
davyvdb CreditAttribution: davyvdb commentedWhich I'm trying to change again because of #346573: Setting administration theme visibility by path and role (other then /admin and content editing now) :) But I need the space with the extra options there. The message is then relavant again!
Comment #15
davyvdb CreditAttribution: davyvdb commentedtagging
Comment #16
mcrittenden CreditAttribution: mcrittenden commentedSubscribe.
Comment #18
davyvdb CreditAttribution: davyvdb commentedComment #20
cburschkaLast test was over a month ago. Pending a re-test, this is RTBC though.
Comment #22
cburschkaHere is a reroll.
Comment #23
PasqualleComment #24
webchickNo more non-critical string changes in D7. And I still maintain my stance that removing this is not a usability improvement.
Comment #25
catch#22: system-admin-theme-msg-556714-22.patch queued for re-testing.
Comment #26
catchComment #28
darvit CreditAttribution: darvit commentedAdded Novice tag
Comment #29
tim-e CreditAttribution: tim-e commentedI cant find the offending code within the current codebase so would say this issue has become obsolete? Im new so im not sure what the process for this is?
Comment #30
borisbaldinger CreditAttribution: borisbaldinger commentedI agree with #29.
As I read the comments i saw, that this issue is really old and a patch was provided. This issue seems to be obsolete and i think it could be closed as most of the discussions are pointing to some UI elements that doesn't exist in Drupal 8 anymore. I had a look at the code and I tested switching the Admin theme myself on my local set up and i don't get the message with the link.
Comment #31
apaderno