Remove backward-compatibility hacks from arg processing [#555446]

The database engine still includes backwards compatibility hacks for supporting sprintf() string replacement in static queries. I haven't heard anything that would make me think this patch would work yet, but it removes what is marked as temporary code for the sprintf() replacement syntax. Send to bot and see how bad it is...

Comment	File	Size	Author
#4	555446_remove_temp_arg_replacement_mysql.patch	2.05 KB	deekayen
#2	remove_temp_arg_replacement_pgsql.patch	1.17 KB	deekayen
	remove_temp_arg_replacement.patch	2.69 KB	deekayen

Comments

Comment #1

21 August 2009 at 05:45

Status:

Needs review

» Needs work

The last submitted patch failed testing.

Comment #2

deekayen commented 21 August 2009 at 05:58

Status:

Needs work

» Needs review

Status	File	Size
new	remove_temp_arg_replacement_pgsql.patch	1.17 KB

Since apparently that's really bad, maybe go more incremental with just removing the pgsql hack.

This isn't enough to close the issue, but it does show whether or not it breaks mysql to remove the pgsql hack.

Comment #3

dries commented 21 August 2009 at 16:38

Status:

Needs review

» Fixed

Committed to CVS. Less is more. Thanks deekayen.

Comment #4

deekayen commented 21 August 2009 at 16:55

Status:

Fixed

» Needs work

Status	File	Size
new	555446_remove_temp_arg_replacement_mysql.patch	2.05 KB

#2 was only a partial fix. There's still a bit remaining with function that needs to be removed. #394182: DBTNG search.module is a prerequisite to removing it, and probably 3-4 other issues I just haven't found yet.