CVS edit link for jbrodbeck

Hi,

I'm stepping in to help co-maintain Ubercart Marketplace (http://drupal.org/project/ubercart_marketplace). I am currently a programmer for a company called Fordela (http://www.fordela.com) and we deploy Drupal for many of our projects as well as Ubercart and Marketplace. Development for Marketplace has dramatically slowed because of the current maintainer's availability. I am offering help in developing version 6.x to a stable production status- and likely help with whatever else comes up. Turgrid (the current maintainer), has created an issue on the project page (http://drupal.org/node/550274) detailing my involvement. Due to his availability, he prefers me to have CVS access as he's too busy to even review patches.

If you need anything else from either of us, please let us know.

Thanks,
Jim Brodbeck

Comments

jbrodbeck’s picture

Status: Postponed (maintainer needs more info) » Needs review

I don't really have a direct contribution other than various patches as I'm not contributing a module from scratch so here's an example of a patch that needs to be committed. A quick summary: this makes sure that only sellers see a seller tab and only when they are on their own account page.

mp_products.module
@@ -38,24 +38,26 @@
global $user;
switch ($op) {
case 'view':
- $link = '';
- if (user_access('view own products')) {
- $link .= l(t('Click here to view your products.'), 'user/'. $account->uid .'/selling/');
- }
- if (module_exists(mp_orders) && user_access('fulfill own orders')) {
- $link .= '
'. l(t('Click here to fulfill your orders.'), 'user/'. $account->uid .'/selling/fulfill');
- }
- if (module_exists(mp_reports) && user_access('view own reports')) {
- $link .= '
'. l(t('Click here to view your sales reports.'), 'user/'. $account->uid .'/selling/reports');
- }
- $account->content['products'] = array(
- '#type' => 'user_profile_category',
- '#title' => t('Selling'),
- 'link' => array(
- '#value' => $link,
- '#type' => 'user_profile_item',
- ),
- );
+ if(user_access('act as seller') && $user->uid == $account->uid){
+ $link = '';
+ if (user_access('view own products')) {
+ $link .= l(t('Click here to view your products.'), 'user/'. $account->uid .'/selling/');
+ }
+ if (module_exists(mp_orders) && user_access('fulfill own orders')) {
+ $link .= '
'. l(t('Click here to fulfill your orders.'), 'user/'. $account->uid .'/selling/fulfill');
+ }
+ if (module_exists(mp_reports) && user_access('view own reports')) {
+ $link .= '
'. l(t('Click here to view your sales reports.'), 'user/'. $account->uid .'/selling/reports');
+ }
+ $account->content['products'] = array(
+ '#type' => 'user_profile_category',
+ '#title' => t('Selling'),
+ 'link' => array(
+ '#value' => $link,
+ '#type' => 'user_profile_item',
+ ),
+ );
+ }
break;
}
}

With CVS access I could go in and commit these changes and others and start resolving issues.

avpaderno’s picture

Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

avpaderno’s picture

Component: Miscellaneous » co-maintainer application
Assigned: Unassigned » avpaderno
Issue summary: View changes
Status: Closed (fixed) » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.