Closed (fixed)
Project:
Drupal.org CVS applications
Component:
new project application
Priority:
Normal
Category:
Task
Assigned:
Issue tags:
Reporter:
Created:
12 Aug 2009 at 15:23 UTC
Updated:
6 Oct 2019 at 20:19 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
nvanhove commentedComment #2
dawehner/**
* Implemenation of hook_foo().
*/
to each hook you implement.
Comment #3
avpadernoSee the Drupal coding standards to understand how a module code should be written.
Comment #4
nvanhove commentedI've adjusted the points given by dereine and used the Coder module to fix some minor coding standard issues.
Comment #5
nvanhove commentedComment #6
ajk commentedShould be
(and elsewhere) otherwise Postgres database users won't use your module
Comment #7
ajk commentedt() ?
Why are you embedding html where themers can't get at it?
element_child()?
Lastly, I'm pretty sure blocks are keyed by module/theme/delta where as you only use module/delta. Did you intend for your descriptions to cover all themes?
Comment #8
nvanhove commentedGood points.
I've adjusted all items and adjusted the module to be keyed by theme/module/delta.
Comment #9
nvanhove commentedWhoops, I uploaded the wrong file..
Comment #10
nvanhove commentedI've removed the module keying theme/module/delta from #7. It appears that blocks are not entirely keyed that way. For example, the title is also reused in all themes.
Please review my module :)
Comment #11
avpadernoComment #14
avpaderno