"Use administration theme for content editing" should include translation [#547162]

Comment	File	Size	Author
#2	node-translate-admin-theme.patch	1.89 KB	drifter
	node-translate-admin-theme.patch	1.89 KB	drifter

Comment #1

drifter commented 12 August 2009 at 14:12

Status:

Active

» Needs review

Log in or register to post comments

Comment #2

drifter commented 12 August 2009 at 14:17

Status	File	Size
new	node-translate-admin-theme.patch	1.89 KB

Sorry, n00b mistake - submitting patch again for the test bot.

Log in or register to post comments

Comment #3

gábor hojtsy

he/him

Hungarian

Hungary

commented 18 August 2009 at 13:23

Looks like a good idea. It might be better to somehow generalize this though, since other contrib actions might want to have the same? This would solve it for core, but what about other contrib modules?

Log in or register to post comments

Comment #4

drifter commented 19 August 2009 at 15:47

Well, where would it make sense to do so? Add an 'admin theme' key to hook_menu, which will trigger the admin theme if TRUE?


  $items['blog/feed'] = array(
    'title' => 'RSS feed',
    'page callback' => 'blog_feed',
    'access arguments' => array('access content'),
    'type' => MENU_CALLBACK,
    'admin theme' => true
  );

Or go further and allow hook_menu to specify an arbitrary theme?

  $items['blog/feed'] = array(
    'title' => 'RSS feed',
    'page callback' => 'blog_feed',
    'access arguments' => array('access content'),
    'type' => MENU_CALLBACK,
    'theme' => variable_get('admin_theme', 0)
  );

Or maybe hook_menu is the wrong place to define this?

Log in or register to post comments

Comment #5

drifter commented 29 August 2009 at 14:42

I see there is a related issue: #346573 Setting administration theme visibility by path and role (other then /admin and content editing now) - which works similarly to the block visibility settings, allowing more pages to use the admin theme. It's a more generalized solution, and doesn't involve hook_menu :)

Then again, I do feel that node/%/translate belongs to the "node editing pages", and you shouldn't need to specify it explicitly.

Log in or register to post comments

Comment #6

seutje commented 5 September 2009 at 13:47

I agree with drifter that we shouldn't explicitly need to do it for this page as it is obviously part of editing content but we do need those underlying mechanisms for allowing contrib modules to specify which pages are admin pages, but I think we would need to split it up in admin_page and node_admin_page so we can still take in account if the user has the "Use the administration theme when editing or creating content" option enabled

Log in or register to post comments

Comment #7

joris_lucius

Dutch

commented 28 September 2009 at 12:36

I couldn't find this that fast for D6. But, if you want also want this implemented in D6, use hook_init in your module:

/**
 * Implementation of hook_init().
 * We use this to get the core translate overview in backend theme.
 */
function MODULENAME_init() {
  if (arg(2) == 'translate') {
       global $custom_theme;
       $custom_theme = variable_get('admin_theme', 0);
  }
}

(not extensively tested yet)