good_man [goodman]

1. The jQuery plugin, and the license file need to be removed.
2. To verify if the current page is the front page, it's enough to call drupal_is_front_page().

3.   global $base_url;
   

   The code doesn't actually use the global variable.

4. 		foreach ($types as $type) {
   			$sql = "SELECT n.nid, n.vid, n.title, teaser FROM {node} n INNER JOIN {node_revisions} r ON n.nid = r.nid "." WHERE n.status=1 AND n.type='" . $type . "' ORDER BY n.created DESC LIMIT $nodes";
   
   			$resource_id = db_query($sql);
   			$resources_array[] = $resource_id;
   			//$nodes_divs .= get_results($resource_id, $image_field, $default_image, $imagecache_preset);
   		}
   

   The code is not correct; it does check the status of the node, but it should also call db_rewrite_sql().

5.   extract($scrollable_options);
   

   I would avoid to use that function, which makes the code error-prone. Looking at the code, it's not possible to say if you are accessing a variable without to first initialize it (which means the code is difficult to maintain).
   If you want to use default values for an array when that array doesn't contain a value, you can use the following code:

     $settings += $default_settings;
   

   In this way, the indexes already present in $settings will not overwritten by indexes present in $default_settings.

6.     $output_body .= '</div>';
   
   	$output_body .= '</div>';
   
   	$output_body .= '<a class="next"></a>'."\n";
   
   	$output_body .= '<br clear="all"/>';
   
       $output_body .= '<script type="text/javascript">';
   
       $output_body .= 'if (Drupal.jsEnabled) {'."\n";
       $output_body .= '$(document).ready(function() {'."\n";
   	$output_body .= '$("#scrollable").scrollable({'."\n";
   	$output_body .= 'size: '.$size.','."\n";
   	$output_body .= 'items: "#thumbs",'."\n";
   

   The code should use a single assignment statement.

7.   function get_results($resources_array, $image_field, $default_image, $imagecache_preset) {
   	global $base_url;
   

   All the function names must be prefixed with the module name; the same is true for the Drupal variables used, and the constant the module defines. See the Drupal coding standards for the other coding suggestion your code is not following.

        foreach ($types as $type) {
            $sql = "SELECT n.nid, n.vid, n.title, teaser FROM {node} n INNER JOIN {node_revisions} r ON n.nid = r.nid "." WHERE n.status=1 AND n.type='" . $type . "' ORDER BY n.created DESC LIMIT $nodes";

            $resource_id = db_query($sql);
            $resources_array[] = $resource_id;
            //$nodes_divs .= get_results($resource_id, $image_field, $default_image, $imagecache_preset);
        }

Also, "LIMIT" shouldn't be used in SQL, pager_query() should be used.

The license file you added to the archive you uploaded here must be removed; the packaging script already adds the same license file. You are probably not allowed to commit a file LICENSE.txt into CVS.
Any third-party files that are available from other sites must not be included in CVS; the same is true for files that are not licensed under GPL License.

@good_man Please don't edit the issue metadata, apart the status.

For an explanation of which code can be added in CVS, see http://drupal.org/node/66113.

What version are you using?

Do you mean that the version you are using is not compatible with the latest version available?

The last version of jQuery Tools is 1.0.2 (June 11, 2009). There is also a version 1.0.3 of jQuery Scrollable (June 3, 2009) on http://plugins.jquery.com/project/scrollable.

Version 1.0.5 is the version for jQuery Scrollable, and 1.0.2 is the version for jQuery Tools.
My point is that jQuery Scrollable 1.0.3 is always present in the jQuery web site; there is no reason to include the file into Drupal CVS when it is available from a third-party site.

There have not been replies from the OP in the past 7 days. I am marking this report as won't fix.

I still don't understand why the code could not use the version available from http://plugins.jquery.com/project/scrollable.

You are right: there is not download link in the jQuery web site; the link I saw is for the release page, which doesn't contain a download link.
In that case, I understand if you include the plugin without module.

I will re-queue your CVS application.

  $items['admin/settings/scrollable_content'] = array(
    'title' => 'Scrollable Content',
    'description' => t('Configure Scrollable Content.'),

The description should not be passed to t().