Closed (fixed)
Project:
RootCandy
Version:
6.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
30 Jul 2009 at 11:54 UTC
Updated:
24 Dec 2010 at 22:10 UTC
Jump to comment: Most recent file
Comments
Comment #1
sign commentedVery nice! Committed
thank you
Comment #2
sign commentedComment #4
abaddon commentedthis patch doesnt allow me to build a subtheme of a rootcandy subtheme, the function isnt running for the subtheme and depending on automatically inheriting the theme-settings.php gets me a broken form, ive fixed it to work on base themes being other rootcandy subthemes too
my theme is a subtheme of rootcandy dark
and i can have a theme-settings.php that inherits everything hence less duplication, like:
(my subtheme is named rootcandy_custom)
Comment #5
abaddon commentedheres a patch to get things moving, and ive replaced the strpos with in_array,
to reiterate this, the initial patch in this thread fixes the case when the subtheme is a subtheme of rootcandy, but i have a subtheme of rootcandy_dark, i just had to change the IF to check for all official rootcandy themes
Comment #6
sign commentedlooking good, committed to dev, some testing would be nice :)