required checkbox not stylized like a required field

Both patches from Zen work for me flawlessly. I'd take the second patch though.

Second patch works. Tested with multiple multiple-select vocabularies. This patch is the same; just makes comment style and terminology consistent.

Now you can not temper with a simple checkbox, before it was not checked. We remove linebreaks from mere textfields, there is no way this breaks user data, only hackers are interested. This puts many header injection attacks at rest. And yes, we care for empty selects. And last, but not least, we make the whole thing readable.

chx' patch works for me.

How about:

+              $form['#value'] = trim($edit);

instead of:

+              $form['#value'] = str_replace(array("\r", "\n"), '', $edit);

Dries, trim does only remove leading or trailing whitespace, not line breaks within the string. Probably use both.

Dries, you do not want to merely remove the ending \r \n but all instances of them. On the other hand, you do not want to remove spaces in the beginning for example. So I fail to see how trim is appropriate here.

Nevermind my comment. chx is right. :)

Tested the patch. Committed to HEAD.

Zend said: "#requireds work as expected on all elements."

The required it on a checkbox is being ignored. The use case for required checkbox is on trms of service agreements and so on. The user should not pass validation until checkbox is checked.

Further, the CSS on a required checkbox is different from other form elements and thus isn't getting styled properly.

Not sure if this report belongs here but is good for now. At least is out of my head.

for testing, the easiest way to add a required checkbox is to use admin/settings/profile

oops. my checkout was stale. the validation works now. class attribute is different though and appears unrequired in bluemarine

chx: Still an active task?

seems fixed to me, using the method from #15 the indicator displayed correctly.