CVS edit link for PeteS

The most immediate motivation is to share a module (tentatively, "Multiple Node Menu") that we have made to enable configuring multiple menu assignments on a node page (i.e., without having to go to the menu section to manually add links). This feature does not seem to exist in any other module, and is still merely a proposal for Drupal 7 that does not seem to have much support as a core capability. The module uses all standard hooks, Ajax/AHAH, and would work very well with Hierarchical Select if HS were to fix a few issues.

We also have a number of other practical modules that we have developed in-house that could be contributed in the future.

Comments

PeteS’s picture

StatusFileSize
new5.05 KB
PeteS’s picture

StatusFileSize
new5.07 KB

Err, had to fix a styling issue.

PeteS’s picture

StatusFileSize
new51.9 KB

Screenshot attached.

AjK’s picture

Status: Postponed (maintainer needs more info) » Needs review
PeteS’s picture

StatusFileSize
new5.12 KB

Replaced tabs with spaces.

avpaderno’s picture

Status: Needs review » Needs work
function menu_multiple_node_menu_install() {
  return;
}

There is no need to define an install function that doesn't do anything.

PeteS’s picture

Status: Needs work » Needs review
StatusFileSize
new5.04 KB

Fair enough. Empty .install function/file removed.

dave reid’s picture

Status: Needs review » Reviewed & tested by the community

Some minor nitpicks:
- I'd remove the package = User interface from the .info since you are not part of a larger module package like Views or CCK.
- Make sure to also remove the last four lines from the .info file as that is going to be added by the drupal.org packaging script automatically, so you should not have those lines in the CVS versions.
- Your access controls on the JS callback should really check user_access('administer menu') and not 'access content' since you are working with menus. This also matches the permission used for actions in menu.module.

Otherwise I think everything looks really really good. Very nice work with this.
-

PeteS’s picture

StatusFileSize
new4.62 KB

All great suggestions, thank you Dave. Those changes are in the latest tarball.

AjK’s picture

Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

avpaderno’s picture

Component: Miscellaneous » new project application
Issue summary: View changes
Status: Closed (fixed) » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.