Deprecated error [#530940]

Comment	File	Size	Author
#1	file.inc_.patch	724 bytes	shaisachs

Comment #1

shaisachs CreditAttribution: shaisachs commented 3 April 2010 at 20:16

Project:	Welcoming Websites Wizard	» Drupal core
Version:	6.x-1.2	» 6.16
Component:	Code	» file system

File	Size
file.inc_.patch	724 bytes

As far as I can tell this is a Drupal core issue, due to an ereg() call in file_scan_directory. The function was deprecated in PHP 5.3, which I guess is the version you have in WAMP.

This patch should take care of it.

Log in or register to post comments

Comment #2

carlmcdade CreditAttribution: carlmcdade commented 6 April 2010 at 07:52

Previous patches have been ignored or lost. The code does work. The new code will even pass the unit test as ereg() would return a 0 or a 1 boolean. preg_match() will do the same by returning the number of hits which would be 0 or 1. Thus matching the requirements of the unit test.

Log in or register to post comments

Comment #3

dddave CreditAttribution: dddave commented 6 April 2010 at 08:23

Status:

Active

» Needs review

Log in or register to post comments

Comment #4

6 April 2010 at 08:40

Status:

Needs review

» Needs work

The last submitted patch, file.inc_.patch, failed testing.

Log in or register to post comments

Comment #5

carlmcdade CreditAttribution: carlmcdade commented 6 April 2010 at 18:48

The patch is failing against the version. But as far as I can see everything is correct and works using patch. But then I am using Windows. Perhaps it is a *nix formatting error. Can someone else try re-rolling this with Linux?