Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.On the forum settings page at /admin/build/forum/settings , the help text reads:
The number of posts a topic must have to be considered "hot".
But "posts" is a generic term: In this case, what's actually meant is "comments". I changed the single word.
This is the second time I've attempted to create a simple patch: My first attempt failed. (See http://drupal.org/node/511986 .) Fingers crossed...
| Comment | File | Size | Author |
|---|---|---|---|
| #9 | forum.admin_.inc_.patch | 599 bytes | tgeller |
| #3 | forum.admin_.inc_.patch | 571 bytes | tgeller |
| forum.admin_.inc_.patch | 572 bytes | tgeller | |
Comments
Comment #1
MichelleIf it's going to be changed, I would sooner see this changed to "replies". Comments are a specific thing in Drupal and, while core does use comments for forum replies, it may not be that way in contrib. Plus, it's keeping more in tune with general forum terminology. I've never heard of any forum software refer to them as comments. They're either "posts" (which generally includes the initial post as well) or "replies" which are all the follow-up posts.
Michelle
Comment #2
EvanDonovan CreditAttribution: EvanDonovan commentedI agree with Michelle. "Comments" would suggest that they were actually Drupal comments, when they might not be stored that way.
"Replies" is much better than "posts", though. Can you re-roll with the word "replies" if you agree & set the issue to "needs review" so the testbot will try your patch?
Comment #3
tgeller CreditAttribution: tgeller commentedDone! Thanks for the guidance.
Comment #4
MichelleThanks, tgeller.
I don't have D7 installed so I can't literally test it, but it's just a one word change and looks fine to me on a "read through".
Michelle
Comment #5
amc CreditAttribution: amc commentedComment #7
Michelle@amc: What is the point in tagging this "forum" when the component is already "forum.module"?
@testing bot: You're on drugs. :P How can changing one word in a string cause failure?
Michelle
Comment #8
John Morahan CreditAttribution: John Morahan commentedyou need to roll the patch from the drupal root and not from within the modules/forum directory, else the testbot won't know where to apply it
Comment #9
tgeller CreditAttribution: tgeller commentedThanks for the help, John Morahan! One mo' time...
Comment #10
Dries CreditAttribution: Dries commentedCommitted to CVS HEAD. Thanks.
Comment #11
amc CreditAttribution: amc commented@Michelle So that people searching by tags and not component can find the issue. Plus it's better than a post that just says "subscribing."