Hi all,
is it possible to correct line 91 of misc/teaser.js to update the JS code to the latest version of JQuery?

The form '[@disabled]' had been deprecated. For people like me using JQuery v1.3.2, this line generates an error.

Please, change
if ($(teaser).is('[@disabled]')) {
to
if ($(teaser).is(':disabled')) {

Regards,
Salvatore.

CommentFileSizeAuthor
#4 teaser-jquery.patch345 bytestuffnatty
#3 teaser-jquery.patch345 bytestuffnatty

Comments

tuffnatty’s picture

tuffnatty commented
Version: 6.13 » 6.15
Status: Active » Reviewed & tested by the community

It really breaks with jQuery 1.3+. The @ in selectors were deprecated in jQuery 1.2 which ships with Drupal by default, so it's perfectly ok to clean this only use of [@type] selector in Drupal core.

jide’s picture

jide commented
Status: Reviewed & tested by the community » Active

This needs a patch first to get RTBC (reviewed & tested by the community) status.

tuffnatty’s picture

tuffnatty commented
Status: Active » Needs review
StatusFileSize
new teaser-jquery.patch345 bytes

Here it is.

tuffnatty’s picture

tuffnatty commented
StatusFileSize
new teaser-jquery.patch345 bytes

My pardon, that patch was a reverse one. Here is the good one.

Status: Needs review » Needs work

The last submitted patch, teaser-jquery.patch, failed testing.

jide’s picture

jide commented

Patches should be first applied to HEAD then be backported, but since this code is not in d7 anymore, obviously we can't.
Just one thing, patches for core should be made from the root of your drupal installation. See http://drupal.org/patch/create.

Edit : Err, sorry, it is.

jide’s picture

jide commented
Status: Needs work » Reviewed & tested by the community

Setting this as RTBC, then.

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Status: Reviewed & tested by the community » Fixed

Committed to Drupal 6, thanks.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.