Update misc/teaser.js to remove deprecated JQuery selection [#510996]

Hi all,
is it possible to correct line 91 of misc/teaser.js to update the JS code to the latest version of JQuery?

The form '[@disabled]' had been deprecated. For people like me using JQuery v1.3.2, this line generates an error.

Please, change
if ($(teaser).is('[@disabled]')) {
to
if ($(teaser).is(':disabled')) {

Regards,
Salvatore.

Comment	File	Size	Author
#4	teaser-jquery.patch	345 bytes	tuffnatty
#4
#3	teaser-jquery.patch	345 bytes	tuffnatty
#3

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

tuffnatty CreditAttribution: tuffnatty commented 4 February 2010 at 22:25

Version:	6.13	» 6.15
Status:	Active	» Reviewed & tested by the community

It really breaks with jQuery 1.3+. The @ in selectors were deprecated in jQuery 1.2 which ships with Drupal by default, so it's perfectly ok to clean this only use of [@type] selector in Drupal core.

Comment #2

jide CreditAttribution: jide commented 5 February 2010 at 02:15

Status:

Reviewed & tested by the community

» Active

This needs a patch first to get RTBC (reviewed & tested by the community) status.

Comment #4

tuffnatty CreditAttribution: tuffnatty commented 5 February 2010 at 18:14

File	Size
teaser-jquery.patch	345 bytes

My pardon, that patch was a reverse one. Here is the good one.

Comment #5

10 February 2010 at 02:50

Status:

Needs review

» Needs work

The last submitted patch, teaser-jquery.patch, failed testing.

Comment #6

jide CreditAttribution: jide commented 10 February 2010 at 03:31

Patches should be first applied to HEAD then be backported, but since this code is not in d7 anymore, obviously we can't.
~~Just one thing, patches for core should be made from the root of your drupal installation. See http://drupal.org/patch/create.~~

Edit : Err, sorry, it is.