Needs work
Project:
Advanced Help Injection and Export
Version:
6.x-1.0-alpha6
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
29 Jun 2009 at 08:49 UTC
Updated:
13 Sep 2009 at 11:07 UTC
Jump to comment: Most recent file
Comments
Comment #1
robertdouglass commentedThanks. First comment - you're changing two things here, and that's generally not a good practice for submitting patches. You're doing the i18n thing (an obvious bug), and you're deciding that there shouldn't be a popup window. The second part needs to be taken out of the patch so that we just focus on fixing the bug.
Comment #2
asak commentedSorry 'bout that - added support for Popups API (added "popups" class) on my site and missed that in the patch...
Attached a cleaner one
Comment #3
robertdouglass commentedSo my next complaint is that we can probably cut down on the extra path* variables.
Comment #4
robertdouglass commented@asak - do you want to pursure this further? Your help is appreciated.