I had a use for Google geocoding with an accuracy below 3 (specifically, 2). Previous issues show this accuracy minimum has already been lowered, but not everyone has a use for less accurate geocoding, so rather than lowering it again, I suggest making it a variable, editable via the Google geocoding configuration form. The attached patch does this.
| Comment | File | Size | Author |
|---|---|---|---|
| #8 | location_accuracy_both2.patch | 5.08 KB | hutch |
| #7 | location_accuracy_both.patch | 5.08 KB | hutch |
| #2 | location_google_maps_accuracy_patch_1.patch | 2.9 KB | pingers |
| accuracyvariable.patch | 2.73 KB | sreynen |
Comments
Comment #1
sreynen commentedThis continues to need review.
Comment #2
pingers commentedI probably should of started with this patch... mine looks similar.
It provides google maps api accuracy settings on a per country level.
Very handy for the project I was working on :)
Comment #3
sreynen commentedA combination of the two would be good, so we can have a default accuracy, and then override that per-country.
Comment #4
yesct commentedyes, could someone review the first patch?
http://drupal.org/patch/review
Maybe it could be committed, then work on a patch to do per country settings based on that one?
Comment #5
yesct commentedjust to clarify, how is this issue different than #747192: precision and scale of locations
?
Comment #6
hutch commentedIt would appear that there *is* a demand for reduced accuracy, I'm a bit surprised but there you have it.
I will review these two patches in the next day or so.
Requirements are (as I understand it):
An overall setting of 1 to 6
A country specific setting of 1 to 6
Both in location configuration form.
It's worth a look at anyway.
Comment #7
hutch commentedI have been over these two patches and found that what they actually do is not reduce accuracy but set a minimum accuracy that will be accepted from Google. That makes a lot more sense.
I have reworked them (patch attached) so that there is a default minimum that can be set under admin/settings/location/geocoding and a per-country setting under the 'Configure parameters' settings. The existing default of '3' remains so nothing changes unless you change it and save configuration.
The files altered by this patch are geocoding/google.inc, location.admin.inc and location.module
Everything seems to be working but it would be good if others could test this, particularly the original posters of the patches.
Comment #8
hutch commentedlocation_accuracy_both.patch has a bug in it, use this one instead, sorry, my bad ;-(
Comment #9
rooby commentedCommitted - http://drupal.org/cvs?commit=372036
[EDIT] Using the patch from #8, thanks to all for the patches.
I changed the country specific variable names to be:
location_geocode_<countrycode>_google_accuracy_codeso it is in line with the existing variables such as:
location_geocode_<countrycode>_google_apikeyAlso, I added the country accuracy setting to location_geocode_au_google_settings() in location.au.inc.
Australia is currently the only country to implement it's own settings form.
As a side note, I don't see any reason for location.au.inc to implement it's own geocode settings form that is the same as the default one.
- See #810840: Remove location_geocode_au_google_settings from location.au.inc (location.xx.inc)
Comment #10
rooby commentedCommitted to head - http://drupal.org/cvs?commit=372060
Comment #11
rooby commentedCommitted to DRUPAL-5--3 - http://drupal.org/cvs?commit=372126