XML encoding conversion broken in PHP5 [#49497]

The behavior of xml_parser($encoding) changed in PHP5 :

Starting from PHP 5, the input encoding is automatically detected, so that the encoding parameter specifies only the output encoding [and not anymore the output encoding].

This change brakes the conversion of encoding of XML documents done by Drupal in function drupal_xml_parser_create() : we now need to change the encoding= parameter in the <?xml ?> tag after the conversion to utf-8.

Among others, this affects the aggregator module.

The included patch is a one-line addition in include/common.inc (in 4.6.5 and lower), or in include/unicode.inc (since 4.7.0).

- DamZ

Comment	File	Size	Author
#7	_49497_php5xml.patch	1.88 KB	Morbus Iff
#7
	drupal_xml_parser.patch	453 bytes	Damien Tournoud

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

Zen CreditAttribution: Zen commented 8 March 2006 at 14:48

Priority:

Critical

» Normal

Downgrading. Please confirm if this is necessary for 4.7 for a better chance of getting this in.

Thanks
-K

Comment #2

Damien Tournoud CreditAttribution: Damien Tournoud commented 8 March 2006 at 18:04

Priority:

Normal

» Critical

This is needed in all code bases since the first implementation of drupal_xml_parser_create(), thus including drupal 4.6.5 AND the current HEAD.

Upgrading the priority again.

- DamZ

Comment #3

Zen CreditAttribution: Zen commented 8 March 2006 at 18:26

Version:

4.6.5

» x.y.z

Please also provide a patch against HEAD and a link to related documentation.

Thanks
-K

Comment #4

Morbus Iff

they/them

CreditAttribution: Morbus Iff commented 8 March 2006 at 18:51

This will not be fixed for 4.6.x. If it were, it gives license (and "but we haveee tOOO!") to backport phptemplate in core (since xtemplate doesn't work in php 5.1.x). Thus, it's a HEAD only issue.