The logic was a little hard to read, but I ran a battery of HumanTests.php, and I'm pretty sure I fixed it.

CommentFileSizeAuthor
#4 vocab-update.patch2.68 KBmfb
#3 extant-vocabulary-validate-fail_0.patch3.2 KBcatch
#1 extant-vocabulary-validate-fail.patch2.65 KBcatch
extant-vocabulary-validate-fail.patch1.01 KBAnonymous (not verified)
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch commented
Priority: Normal » Critical
FileSize
extant-vocabulary-validate-fail.patch2.65 KB

Wrote tests for failed validation, but looks like passing validation wasn't properly tested.

Changed the tests so they'll fail without this patch now.

Status: Needs review » Needs work

The last submitted patch failed testing.

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch commented
Status: Needs work » Needs review
FileSize
extant-vocabulary-validate-fail_0.patch3.2 KB
mfb’s picture

mfb
they or he
CreditAttribution: mfb commented
FileSize
vocab-update.patch2.68 KB

I took out a layer of parentheses for what seems like more readable logic. But if someone likes that stuff they can go with #3.

Sivaji_Ganesh_Jojodae’s picture

Sivaji_Ganesh_Jojodae CreditAttribution: Sivaji_Ganesh_Jojodae commented

#4 works fine for me.

Anonymous’s picture

Anonymous (not verified) CreditAttribution: Anonymous commented
Status: Needs review » Reviewed & tested by the community

I agree.

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch commented
Issue tags: +Quick fix

I thought this was in already, then went to edit a vocabulary and found it wasn't. rrrtbc.

Dries’s picture

Dries CreditAttribution: Dries commented
Status: Reviewed & tested by the community » Fixed

Committed to CVS HEAD. Thanks.

Status: Fixed » Closed (fixed)
Issue tags: -Quick fix

Automatically closed -- issue fixed for 2 weeks with no activity.

Issue tags: +Quick fix

Restoring issue tags, see #2125755: System messages removed all issue tags during D7 upgrade.