Wikipedia affirms the commonality of CRUD in user interfaces: http://en.wikipedia.org/wiki/Create,_read,_update_and_delete#User_interface. However, admin/content/taxonomy/tanonomyID is missing one of the atomic CRUD operations: delete. That operation requires a three step process:

  1. Click edit link.
  2. Click Delete button.
  3. Click Delete button (on different page).

Please expose delete as a first-order function on the taxonomy list page.

I suspect this is a Drupal design pattern. If so, I hope it can be revisited for the entire product.

Files: 
CommentFileSizeAuthor
#13 terms-list-post-patch-3.png52.05 KBBTMash
#13 terms-list-post-patch-2.png42.8 KBBTMash
#13 terms-list-post-patch-1.png56.23 KBBTMash
#13 terms-list-pre-patch-3.png42.46 KBBTMash
#13 terms-list-pre-patch-2.png73.77 KBBTMash
#13 terms-list-pre-patch-1.png53.72 KBBTMash
#12 490182-add_delete_operation_to_taxonomy_overview_terms-12.patch13.07 KBamateescu
PASSED: [[SimpleTest]]: [MySQL] 34,614 pass(es).
[ View ]
#6 490182-add_delete_operation_to_taxonomy_overview_terms-3.patch12.98 KBamateescu
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch 490182-add_delete_operation_to_taxonomy_overview_terms-3.patch. This may be a -p0 (old style) patch, which is no longer supported by the testbots.
[ View ]
#4 490182-add_delete_operation_to_taxonomy_overview_terms-2.patch10.99 KBamateescu
PASSED: [[SimpleTest]]: [MySQL] 34,341 pass(es).
[ View ]
#2 490182-add_delete_operation_to_taxonomy_overview_terms.patch11.31 KBamateescu
FAILED: [[SimpleTest]]: [MySQL] 34,318 pass(es), 6 fail(s), and 2 exception(es).
[ View ]

Comments

sun.core’s picture

Version:7.x-dev» 8.x-dev
amateescu’s picture

Status:Active» Needs review
StatusFileSize
new11.31 KB
FAILED: [[SimpleTest]]: [MySQL] 34,318 pass(es), 6 fail(s), and 2 exception(es).
[ View ]

I wanted to do this for a very long time, so, finally, here's a patch :)

Status:Needs review» Needs work

The last submitted patch, 490182-add_delete_operation_to_taxonomy_overview_terms.patch, failed testing.

amateescu’s picture

Status:Needs work» Needs review
StatusFileSize
new10.99 KB
PASSED: [[SimpleTest]]: [MySQL] 34,341 pass(es).
[ View ]

Now with passing tests..

amateescu’s picture

Category:feature» task
StatusFileSize
new12.98 KB
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch 490182-add_delete_operation_to_taxonomy_overview_terms-3.patch. This may be a -p0 (old style) patch, which is no longer supported by the testbots.
[ View ]

Rerolled after #1375134: Random test failure in TaxonomyTermTestCase::testNodeTermCreationAndDeletion(). And this looks more like a task to me, we're not asking for anything more than UX consistency here :)

xjm’s picture

Issue tags:+Novice, +Needs screenshots

Before-and-after screenshots would be helpful here. Tagging as novice to:

  1. Test the behavior before the patch.
  2. Take screenshots before the patch.
  3. Apply the patch.
  4. Test the behavior after the patch.
  5. Take screenshots after the patch.
  6. Report your results here. :)
BTMash’s picture

Status:Needs review» Needs work
Issue tags:+Usability, +Novice, +Needs screenshots

The last submitted patch, 490182-add_delete_operation_to_taxonomy_overview_terms-3.patch, failed testing.

BTMash’s picture

Status:Needs work» Needs review

I ran into an issue while trying to apply the patch so I've queued the patch for retesting to ensure it is not user error. I suspect this may have to do with the crud api coming in.

BTMash’s picture

Status:Needs review» Needs work

Setting back to needs work.

amateescu’s picture

Status:Needs work» Needs review
StatusFileSize
new13.07 KB
PASSED: [[SimpleTest]]: [MySQL] 34,614 pass(es).
[ View ]

Re-rolled against latest HEAD.

BTMash’s picture

Status:Needs review» Reviewed & tested by the community
StatusFileSize
new53.72 KB
new73.77 KB
new42.46 KB
new56.23 KB
new42.8 KB
new52.05 KB

Ok, so after some user related issues (cache clearing), I can confirm that the test works. My work flow was:

1) Go to the term list page.
Terms listed for a vocabulary. Missing delete action

2) I see the delete action is missing. So I click on edit.
Term edit page. Contains delete button.
3) I see the delete action button and click on it.
Term delete page. Can finally delete term.
I would finally be able to delete the term.

At this stage I apply the patch.
4) I go back to the term list page.
Term edit page post patch. Contains delete action.
5) I saw the delete action link and clicked on it.
Term delete page. Can delete term.
6) Just to confirm, I tried to delete the term and it was successful.
Term deletion was successful.

Bojhan’s picture

Looks fine, wish we would document a standard for this

Dries’s picture

Status:Reviewed & tested by the community» Fixed

Committed to 8.x. Thanks! Glad to see some UX improvements go in.

Bojhan’s picture

Status:Fixed» Needs work
Issue tags:-Usability, -Novice, -Needs screenshots+Needs Documentation

Awesome! Lets make sure we document this new standard in http://drupal.org/ui-standards - that we have delete as a operations in all tables.

BTMash’s picture

Just so I understand, are ux improvements like this only being done for 8.x or will there be backports to 7.x?

Bojhan’s picture

only 8

scottalan’s picture

Assigned:Unassigned» scottalan

Working...

xjm’s picture

Hi scottalan,

Are you still working on this issue?

scottalan’s picture

I have gotten off track... I will touch base with zendoodles on this one to get more direction.