drush cron reports success even if the cron run fails (i.e. cron is already running or there is a stale semaphore)

CommentFileSizeAuthor
#5 drush-cron-fail.patch741 bytesJohn Morahan
#2 drush-cron-fail.patch732 bytesJohn Morahan
drush-cron-fail.patch707 bytesJohn Morahan
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

moshe weitzman’s picture

moshe weitzman CreditAttribution: moshe weitzman commented
Status: Needs review » Needs work

Good catch. We should use drush_error() and drush_log() instead of drush_print()

John Morahan’s picture

John Morahan CreditAttribution: John Morahan commented
Status: Needs work » Needs review
FileSize
drush-cron-fail.patch732 bytes

Ah... like this?

moshe weitzman’s picture

moshe weitzman CreditAttribution: moshe weitzman commented

The success message should be drush_log(dt('Cron successfully run'), 'success') or somesuch.

John Morahan’s picture

John Morahan CreditAttribution: John Morahan commented
Status: Needs review » Needs work

Oh, wait, you meant drush_log for success.

John Morahan’s picture

John Morahan CreditAttribution: John Morahan commented
Status: Needs work » Needs review
FileSize
drush-cron-fail.patch741 bytes
moshe weitzman’s picture

moshe weitzman CreditAttribution: moshe weitzman commented
Status: Needs review » Fixed

committed. thx.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.