sites/all/* does not override out-dated versions of modules/themes in profiles directory [#480044]

So there's an interesting code comment in drupal_system_listing().

The 'profiles' directory contains pristine collections of modules and themes as organized by a distribution. It is pristine in the same way that /modules is pristine for core; users should avoid changing anything there in favor of sites/all or sites/ directories.

In other words, the comments imply that if you want to override a module included in a profile with a newer version, you should put it in sites/all or sites/<config> directories.

However, drupal_system_listing() actually looks for modules in this order: (later searches override earlier searches)

modules
sites/all/modules
profiles/<current-profile>/modules
<current-config>/modules (like sites/default/modules or sites/org.example/modules)

Which means that modules in sites/all/modules cannot override the older, out-of-date versions of themselves in profiles directory.

Comment	File	Size	Author
#6	sites-all-override-480044-6-D6.patch	1.09 KB	JohnAlbin
#6
#1	sites-all-override-480044-1.patch	1.07 KB	JohnAlbin
#1

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

File	Size
sites-all-override-480044-1.patch	1.07 KB

Comment #2

Crell CreditAttribution: Crell commented 2 June 2009 at 20:24

This could probably be backported to D6, too. Subscribing. :-)

Comment #3

catch

he/him

English

CreditAttribution: catch commented 2 June 2009 at 22:46

Status:

Needs review

» Reviewed & tested by the community

Simple patch, impossible to write a test for. RTBC.

Comment #4

dman CreditAttribution: dman commented 3 June 2009 at 02:46

catch - June 3, 2009 - 10:46
"Simple patch, impossible to write a test for. RTBC."

... we'll put that on your tombstone.
;-)

Comment #5

webchick

she/they

English

Vancouver 🇨🇦

CreditAttribution: webchick commented 3 June 2009 at 02:57

Version:	7.x-dev	» 6.x-dev
Status:	Reviewed & tested by the community	» Patch (to be ported)

Makes sense. Committed to HEAD.

Interestingly, this doesn't apply to D6:

webchicks-macbook-pro:6x webchick$ patch -p0 < sites-all-override-480044-1.patch 
patching file includes/common.inc
Reversed (or previously applied) patch detected!  Assume -R? [n]

However, I can see with my own two eyes that it's not fixed there, so I guess this needs a re-roll?

File	Size
sites-all-override-480044-6-D6.patch	1.09 KB

Comment #7

eabrand CreditAttribution: eabrand commented 6 July 2009 at 19:02

Just tested. It works!

Comment #8

eabrand CreditAttribution: eabrand commented 6 July 2009 at 19:05

Status:

Needs review

» Reviewed & tested by the community

Comment #9

Gábor Hojtsy

he/him

Hungarian

Hungary

CreditAttribution: Gábor Hojtsy commented 14 September 2009 at 08:10

Status:

Reviewed & tested by the community

» Fixed

Although I was a little bit concerned that existing sites possibly depending on this order might break, after much thinking I figured there would probably be a very limited number of sites and they should not hold us back from having a solid core setup supporting distributions, so they can thrive. Committed to Drupal 6!