Commands do not escape spaces in directory names

Yeah. If I have some time today I'll further try to debug it and put together a patch, but I had my site at /User/Documents/public_html/inreview and I could update from there, but when I tried to run an update command via the actual directory (the above dir is a symlink from /Users/Documents/workspace/Local inReview Trunk) then it did not work. When I tried updating within the path with spaces, it at first looked OK, but when I ran it with --verbose=2 I found that the "tar" commands were erroring out because it exected the space to start the next part of the "tar" command. Hope that helps.

Here's a snippet from the verbose output of the operation:

Starting to update Views code ...                                       [notice]
Backup skipped because .svn directory was detected. Use Subversion to   [notice]
revert if needed.
Downloading project views ...                                           [notice]
Executing: wget http://ftp.drupal.org/files/projects/views-6.x-2.5.tar.gz
  sh: wget: command not found
Executing: curl -O http://ftp.drupal.org/files/projects/views-6.x-2.5.tar.gz
    % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                   Dload  Upload   Total   Spent    Left  Speed
100 1387k  100 1387k    0     0   125k      0  0:00:11  0:00:11 --:--:--  157k
Downloading views-6.x-2.5.tar.gz was successful.                        [notice]
Md5 checksum of views-6.x-2.5.tar.gz verified.                          [notice]
Executing: gzip -d views-6.x-2.5.tar.gz
Executing: tar -xf views-6.x-2.5.tar -C /Users/Dan/Documents/workspace/Local inReview Trunk/sites/all/modules/
  tar: inReview: Not found in archive
  tar: Trunk/sites/all/modules: Not found in archive
  tar: Error exit delayed from previous errors
Calling unlink(views-6.x-2.5.tar)
Project views was updated successfully. Installed version is now 6.x-2.5.

OK, here's a patch that fixed it for me. I just put quotes around the path that had spaces and now it works.

I think the version I downloaded from CVS was the HEAD version, so I'm changing the tag, but this line looked the same in the All-Versions-2.0-rc1 version.

I came across this problem again with some of the code for checking the status of the SVN repository before upgrade. A patch is included to add quotes around the path. This fixes the problem where the cd command does not recognize a path with spaces in it (at least it doesn't work on my Mac without this patch).

Actually, this patch adds the quote to allow spaces in a couple other places as well and worked a bit better in my case.