If you disable javascript support in your browser and load the node add page you can see a

<div class="vertical-tabs clear-block"> </div>

See the attached screenshot. I have not verified if this is also in D7.

CommentFileSizeAuthor
#3 vertical_tabs-475850.patch1.24 KBles lim
vertical_tabs_no_js_bug.png3.98 KBhass

Comments

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented

Can you verify this happens in the latest version?

hass’s picture

hass commented
Version: 6.x-1.0-beta3 » 6.x-1.0-beta4

Yes, it is still shown in the latest release.

les lim’s picture

les lim
he/they
Primary language English
commented
Version: 6.x-1.0-beta4 » 6.x-1.x-dev
Assigned: Unassigned » les lim
Status: Active » Needs review
StatusFileSize
new vertical_tabs-475850.patch1.24 KB

Yes, this is still there. The module uses Form API to create the Vertical Tabs container and JS to move the fieldsets into it, but if javascript is unavailable, we'll still be left with an empty DIV that has a border but no tabs.

One solution is to hide the Vertical Tabs container in the default CSS and show it with JS when the interface is being processed. Patch attached.

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Status: Needs review » Fixed

Tested and works just fine. Committed to CVS (http://drupal.org/cvs?commit=285296). Thanks!

les lim’s picture

les lim
he/they
Primary language English
commented
Assigned: les lim » Unassigned
Status: Fixed » Active

Hold on, is this the right approach? What if there's a case in which a themer wants to use CSS to hide vertical tabs for some reason? Using javascript to forcibly show the interface will always override that intent. This may be worth further thought.

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Status: Active » Fixed

Best way is to backport the D7 JavaScript code to manipulate the elements inside the and show those only. For now, this is the best approach. If you have a patch, please open a new issue.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.