I think the garland logo is vertically misaligned. The problem becomes more obvious if a gradient with more distinct colors than the default color scheme is used. Please see the attached screenshot. The problem could probably be fixed by shifting the logo up perhaps two pixels.

CommentFileSizeAuthor
#17 garland_logo_6x.patch552 bytespsicomante
#16 garland_logo_6x.patch552 bytespsicomante
#3 garland.patch572 bytesbleen
garland_logo_misaligned.png6.6 KBcwgordon7

Comments

cwgordon7’s picture

cwgordon7 commented
Issue tags: +Novice

Adding the novice tag - I could do this myself, but it could also be a great opportunity for someone to learn about the patch cycle. :) Minimal CSS knowledge is probably required. Feel free to ping me on IRC (cwgordon7) if you need help.

zserno’s picture

zserno commented

Tried to change Garland color scheme to Ash, but color.module seems broken: #497948: Color module is broken
I'll be able to continue when that bug is fixed.

bleen’s picture

bleen commented
StatusFileSize
new garland.patch572 bytes

Ok ... trying to get my feet wet on contributing to core. This seemed like a good opportunity to try without annoying too many people. I attached a patch file (I think I did it right) that addresses this bug. Now what?

axyjo’s picture

axyjo commented
Status: Active » Needs review

After you upload a patch, you should mark the issue as CNR (needs review) if you believe that you pass all of the guidelines. If not, you set it to CNW (needs work). I think this patch was pretty simple, so I'll mark it CNR for you. The reason it's not RTBC yet is because I haven't run tests on it.

cwgordon7’s picture

cwgordon7 commented
Status: Needs review » Reviewed & tested by the community

This is beautiful! Awesome work!

sivaji_ganesh_jojodae’s picture

sivaji_ganesh_jojodae commented
Issue tags: +Quick fix

attaching "quick fix" tag.

dries’s picture

dries commented
Version: 7.x-dev » 6.x-dev
Status: Reviewed & tested by the community » Needs review

Committed to CVS HEAD. Probably requires back porting to Drupal 6 -- not 100% sure. Updating status and version information accordingly.

Thanks bleen18. :)

bleen’s picture

bleen commented

Cool beans ... thanks!

psicomante’s picture

psicomante commented

tested on Drupal 6. It works perfectly. see drupal italia.

psicomante’s picture

psicomante commented
Status: Needs review » Reviewed & tested by the community
axyjo’s picture

axyjo commented
Status: Reviewed & tested by the community » Fixed

Well, if it works without modification ...

psicomante’s picture

psicomante commented

eh? i don't understand.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented

@axyjo: Psicomante maybe meant that the patch works on Drupal 6 too; then, the logo image have that problem with the theme Garland on Drupal 6 too.

axyjo’s picture

axyjo commented
Status: Fixed » Needs review

Sorry, I guess I misunderstood.

cwgordon7’s picture

cwgordon7 commented
Status: Needs review » Reviewed & tested by the community

...

psicomante’s picture

psicomante commented
StatusFileSize
new garland_logo_6x.patch552 bytes

patch for drupal 6 branch.

psicomante’s picture

psicomante commented
StatusFileSize
new garland_logo_6x.patch552 bytes

Mr.Bot is in holiday :D

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Status: Reviewed & tested by the community » Needs review

Maybe it is because the status is not "needs review".

psicomante’s picture

psicomante commented

Or is it for 6.x?

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented

I guess you are right; all times it gets in action, the patch is proposed for Drupal 7 (or HEAD CVS).

cwgordon7’s picture

cwgordon7 commented
Status: Needs review » Reviewed & tested by the community
gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Status: Reviewed & tested by the community » Fixed

Committed to Drupal 6, thanks!

Status: Fixed » Closed (fixed)
Issue tags: -Quick fix, -Novice

Automatically closed -- issue fixed for 2 weeks with no activity.

Issue tags: +Quick fix, +Novice

Restoring issue tags, see #2125755: System messages removed all issue tags during D7 upgrade.