Pager doesn't display right ellipsis if there is only one page left

It seems like the above patch has been committed, but it is not quite correct.

Instead of:

      if ($i < $pager_max) {
        $items[] = array(
          'class' => array('pager-ellipsis'),
          'data' => '…',
        );
      }

It should read: (note $pager_max+1 in the conditional)

      if ($i < $pager_max+1) {
        $items[] = array(
          'class' => array('pager-ellipsis'),
          'data' => '…',
        );
      }

In D6 this will be:

      if ($i < $pager_max+1) {
        $items[] = array(
          'class' => 'pager-ellipsis',
          'data' => '…',
        );
      }

Pager in D7 has changed a lot; does the issue still exist? If not you can move this to D6.

The issue is exists, #2 solves it, i've turned into patch.

Great, it seems work.

But, please see the coding stnadards for operators: http://drupal.org/coding-standards#operators

All binary operators (operators that come between two values), such as +, -, =, !=, ==, >, etc. should have a space before and after the operator, for readability. For example, an assignment should be formatted as $foo = $bar; rather than $foo=$bar;.

And this issue needs automated tests.

...again with using coding standards

Works fine. Thanks.

Haven't tested Drupal 8, but the same code exists there, so I assume it would need to be fixed there first.

patch for 7.26

Works perfectly!

Still seeing similar code in Drupal 8, and no indication from anyone that the bug doesn't exist there.

The test failed on queries, so re-testing.

This patch fix the problem, I tested it on Drupal 7.

It looks like the proposed patches are for D7.
So why is this issue in D8 version?
You cannot test D7 patches against D8 and expect them to pass.

Are we not supposed to create a new issue with correct Drupal version and submit
patches with correct versions so they could be tested properly?

Correct me if I'm wrong
-------------------------------------------------
Sponsored by http://reallifedesign.co.uk/

Cannot replicate in D8. So moving this to original D7 version

-------------------------------------------------
Sponsored by http://reallifedesign.co.uk/

I've posted exactly the same patch in #6 and was confirmed in #7.
The issue needs the D8 fix now.

Ok, I've looked after: the bug exists in D8, here is the patch for it.
I've tested, works well.

Ellipsis is shown indeed in D8.

Tested with and without patch.

With patch:

Without patch:

Sorry, I think this needs tests before it can be committed. We want to avoid this from regressing again.

You'll probably want to expand \Drupal\system\Tests\Pager\PagerTest.

I'll work on the test

Great! But we also need a test for the case where the ellipsis is expected to not yet appear.

Test has been updated!

+++ b/core/modules/system/src/Tests/Pager/PagerTest.php
@@ -99,9 +99,18 @@ protected function testPagerQueryParametersAndCacheContext() {
+    $elements = $this->cssSelect(".pager__item--ellipsis:contains('…')");
+    $this->assertEqual(count($elements), 0, 'No ellipsis has been set.');

Clever! :) Love it!

Excellent test — hope to see you around more often in the D8 core issue queue :)

+++ b/core/modules/system/src/Tests/Pager/PagerTest.php
@@ -96,6 +96,29 @@ protected function testPagerQueryParametersAndCacheContext() {
   /**
+   * Test proper functioning of the ellipsis.
+   */
+  protected function testPagerEllipsis() {

This needs to be public. Yes it still works with protected and I know that another method in this test is incorrectly marked as protected but we should still get this one correct.

Oops, should've caught that. Sorry, Alex.

Patch has been updated!

Made a mistake with previous patch in #44.
Should be ok now.
Function changed from protected to public.

Looks like this is rtbc.
Function is now public as requested in #42

Manual testing proves this fix is correct. Nice work. Committed 88470f9 and pushed to 8.0.x. Thanks!

The patch in #5 and #23 (same patch) are already reviewed and tested a log time ago, including by me ;)

The tests need to be backported from Drupal 8 also.

Patch for D7 with test.