i exported quite a lot of views to code yet, and everytime i thought that providing also a info file would be cool.

so here is a patch, i think there should be better texts

PS: i added a screenshot to show how it works

CommentFileSizeAuthor
#2 views-export-info-no-t.patch1.26 KBdawehner
views-export-info_file.patch1.73 KBdawehner
screenshot61.png21.26 KBdawehner

Comments

merlinofchaos’s picture

merlinofchaos commented
Status: Needs review » Fixed

Committed!

dawehner’s picture

dawehner
Primary language German
commented
Status: Fixed » Needs review
StatusFileSize
new views-export-info-no-t.patch1.26 KB

sry for opening it i think this shouldn't have t() to generate the output. There should be only strtr

merlinofchaos’s picture

merlinofchaos commented

Why bother with strtr then? Just generate the string through concatenation.

dawehner’s picture

dawehner
Primary language German
commented

i just orientated on the other code of the function 

<?php
  $api .= "    //'path' => drupal_get_path('module', '@module') . '/includes',\n";
  $api .= "  );\n";
  $api .= "}";

  $api = strtr($api, array('@module' => check_plain($form_state['values']['name'])));

?>

But it wouldn't be a problem to change the code

merlinofchaos’s picture

merlinofchaos commented
Status: Needs review » Fixed

Committed to both branches.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.