Doing a quick E_STRICT run of a patch I was working I found out a bunch of our tests don't have getInfo as a static method. The attach patch fixes these methods.

CommentFileSizeAuthor
test_strict_getInfo_followup.patch2.82 KBneclimdul
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

neclimdul’s picture

Issue tags: +trivial

tagging trivial

c960657’s picture

Status: Needs review » Reviewed & tested by the community

Looks good to me.

FYI, other work to get rid of E_STRICT notices are going on in #325827: Avoid PHP strict timezone warnings by calling date_default_timezone_set in bootstrap and #348448: Always report E_STRICT errors.

catch’s picture

NancyDru’s picture

Then, as I said in the other issue, this needs to be committed ASAP.

boombatower’s picture

Looks good.

webchick’s picture

Status: Reviewed & tested by the community » Fixed

Thanks, folks! Committed to HEAD. I'll try to be more conscientious about this from now on, cos I know I've let a couple slip. :\

NancyDru’s picture

Thanks, Angie. Hey, 27 hrs from RTBC is pretty darn good for core...

Status: Fixed » Closed (fixed)
Issue tags: -trivial

Automatically closed -- issue fixed for 2 weeks with no activity.