Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
Doing a quick E_STRICT run of a patch I was working I found out a bunch of our tests don't have getInfo as a static method. The attach patch fixes these methods.
Comment | File | Size | Author |
---|---|---|---|
test_strict_getInfo_followup.patch | 2.82 KB | neclimdul | |
Comments
Comment #1
neclimdultagging trivial
Comment #2
c960657 CreditAttribution: c960657 commentedLooks good to me.
FYI, other work to get rid of E_STRICT notices are going on in #325827: Avoid PHP strict timezone warnings by calling date_default_timezone_set in bootstrap and #348448: Always report E_STRICT errors.
Comment #3
catchExactly the same patch was posted at #454396: getInfo() not declared as static for various core tests.
Comment #4
NancyDruThen, as I said in the other issue, this needs to be committed ASAP.
Comment #5
boombatower CreditAttribution: boombatower commentedLooks good.
Comment #6
webchickThanks, folks! Committed to HEAD. I'll try to be more conscientious about this from now on, cos I know I've let a couple slip. :\
Comment #7
NancyDruThanks, Angie. Hey, 27 hrs from RTBC is pretty darn good for core...