Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.In testing #220592: Core cache API breaks update.module: fetches data way too often, kills site performance, etc, I noticed that the code which tries to clear the cache of update status data when you save the admin/build/themes page (on the assumption that you enabled/disabled a theme and it should be recomputed -- just like we do for admin/build/modules) is actually broken in both D6 and HEAD since the form_id is inconsistent between the modules and themes pages. :( However, this is a totally separate bug from #220592 and I didn't want to creep Yet Another(tm) fix into that (already giant patch). I also don't think this is nearly as urgent to fix, so I'm just submitting a separate issue about it.
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | 448268-2.update_clear_cache_themes.d7.patch | 657 bytes | dww |
| #1 | 448268-1.update_clear_cache_themes.d6.patch | 712 bytes | dww |
Comments
Comment #1
dwwThe patch isn't going to apply cleanly to HEAD due to conflicts with the latest patch for #220592, but this one will apply cleanly to D6. As soon as #220592 lands, we can easily reroll this for HEAD.
Comment #2
dwwNow that #220592: Core cache API breaks update.module: fetches data way too often, kills site performance, etc is in, here's an untested patch for D7/HEAD.
Comment #3
dwwThis issue is encouragement for killing kittens. I found this bug while working on #220592: Core cache API breaks update.module: fetches data way too often, kills site performance, etc, thought I was doing the core committers a favor by posting it separately, but this has languished without reply. This bug would already be fixed in 6.11 and HEAD if I had just included the 1-line fixes in my final patches for #220592, but by following the suggested core development workflow, the code is still broken. :(
It's a trivial fix, tested in D6, the bot likes it in D7... Might as well RTBC my own patch.
Comment #4
sun.
Comment #5
webchickCommitted.
Btw, I don't really see the reason for sour grapes here; a simple final reply at the bottom of the thread that 5000 people were already looking at that said "Btw, don't forget about #448268: Cached update status data not cleared when saving theme admin page due to wrong form_id" would've seen this RTBCed (and thus within core committer view) within minutes, I'm betting. Use that strategy from now on, rather than including a link off to it as a side-note in the middle of a several-paragprah long reply in the middle of a thread with 50+ replies. Yes, things do tend to fall through the cracks that way.
Comment #6
Gábor HojtsyCommitted to Drupal 6 too.
Comment #7
dwwThanks, folks.
@webchick: You're right, I should have made more of a stink in the other issue about this...