Probably not now that we require PHP5.

CommentFileSizeAuthor
#8 444876-remove-node-invoke-all.patch1.58 KBdamien tournoud
#4 444876-remove-node-invoke-all.patch10.21 KBdamien tournoud
#1 444876-remove-node-invoke-all.patch7.85 KBdamien tournoud

Comments

damien tournoud’s picture

damien tournoud commented
Status: Active » Needs review
StatusFileSize
new 444876-remove-node-invoke-all.patch7.85 KB
dries’s picture

dries commented

This should go in, after the test bot did his thing.

Status: Needs review » Needs work

The last submitted patch failed testing.

damien tournoud’s picture

damien tournoud commented
Status: Needs work » Needs review
StatusFileSize
new 444876-remove-node-invoke-all.patch10.21 KB

Crap. We removed the $page parameter and failed to properly update the book, trigger and upload.

Here is an updated patch.

Status: Needs review » Needs work

The last submitted patch failed testing.

damien tournoud’s picture

damien tournoud commented

Failures in the book module are due to #444920: Book breadcrumbs are broken.

dries’s picture

dries commented

This patch only applied partially but I've committed what did apply and what did test properly.

There is more node_invoke_node() stuff to be deleted (e.g. the actual function, documentation) so I'm switching this back to 'code needs work'.

I accidentally committed this with #19837 -- sorry! I will give proper credit in the next commit.

damien tournoud’s picture

damien tournoud commented
Status: Needs work » Needs review
StatusFileSize
new 444876-remove-node-invoke-all.patch1.58 KB

This should take care of the remaining pieces.

dries’s picture

dries commented
Status: Needs review » Needs work

Committed to CVS HEAD. Thanks DamZ. Marking this 'code needs work'. Mark 'fixed' after documentation updates.

damien tournoud’s picture

damien tournoud commented
Status: Needs work » Fixed

Added entry for this in the two subpages of http://drupal.org/node/394066.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.