CP field should only show that attributes what are really available for mapping. So on provider side, if openid_provider_ax is not here, do not show AX attribs. If openid_provider_sreg is not installed, hide SReg attribs. If neither is installed, warn the user to take action :)

CommentFileSizeAuthor
#5 openid_cp_field_mising_modules_and_revert_accidental_commit.patch4.65 KBaron novak
#2 openid_cp_field_mising_modules.patch2.04 KBalex_b
#1 openid_cp_field_mising_modules.patch2.04 KBaron novak

Comments

aron novak’s picture

aron novak
Primary language Hungarian
Location Hungary, Budapest
commented
Status: Active » Needs review
StatusFileSize
new openid_cp_field_mising_modules.patch2.04 KB

Here is a patch what takes care of missing modules and do not show nonsense attributes (SReg fields when Sreg module is not available, for example)

alex_b’s picture

alex_b commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new openid_cp_field_mising_modules.patch2.04 KB

Fixed some language. RTBC.

darren.ferguson’s picture

darren.ferguson commented

Alex, does not want to patch based off the current cvs

[darren@myhost openid_cp_field]$ patch -i openid_cp_field_mising_modules_0.patch
patching file openid_cp_field.module
Hunk #1 FAILED at 91.
1 out of 1 hunk FAILED -- saving rejects to file openid_cp_field.module.rej

alex_b’s picture

alex_b commented
Status: Reviewed & tested by the community » Needs work

This may fight due to the recent commits - Aron could you have a look? Thank you.

aron novak’s picture

aron novak
Primary language Hungarian
Location Hungary, Budapest
commented
Status: Needs work » Needs review
StatusFileSize
new openid_cp_field_mising_modules_and_revert_accidental_commit.patch4.65 KB

I re-rolled the patch.
This one includes the revert of an accidental commit.

alex_b’s picture

alex_b commented
Status: Needs review » Fixed

Committed.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.