PDOException: SELECT COUNT(*) AS expression FROM {block} block WHERE (module = :db_condition_placeholder_6) AND (delta = :db_condition_placeholder_7) AND (status = :db_condition_placeholder_8) - Array ( [:db_condition_placeholder_6] => user [:db_condition_placeholder_7] => online [:db_condition_placeholder_8] => 1 ) SQLSTATE[42S02]: Base table or view not found: 1146 Table 'dp7.block' doesn't exist in system_performance_settings() (line 1306 of E:\phpnow\htdocs\dp7\modules\system\system.admin.inc).

CommentFileSizeAuthor
#15 issue_427296_v4.patch2.86 KBtaz88ny
#10 issue_427296_v3.patch1.88 KBtaz88ny
#5 issue_427296_v2.patch1.75 KBtaz88ny
#4 issue_427296.patch1.46 KBtaz88ny
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

reus’s picture

reus CreditAttribution: reus commented
Assigned: reus » Unassigned
taz88ny’s picture

taz88ny CreditAttribution: taz88ny commented
Assigned: Unassigned » taz88ny
stewsnooze’s picture

stewsnooze
he / him
CreditAttribution: stewsnooze commented
Assigned: taz88ny » Unassigned

subscribe

taz88ny’s picture

taz88ny CreditAttribution: taz88ny commented
Assigned: Unassigned » taz88ny
Status: Active » Needs review
FileSize
issue_427296.patch1.46 KB

I added a condition to check if the table exists before attempting to run the query.

Not all modules have to be disabled and uninstalled, only the blocks module needs to be uninstalled to reproduce the error.

taz88ny’s picture

taz88ny CreditAttribution: taz88ny commented
FileSize
issue_427296_v2.patch1.75 KB

Indented the code inside of the condition I added.

taz88ny’s picture

taz88ny CreditAttribution: taz88ny commented
Status: Needs review » Needs work
taz88ny’s picture

taz88ny CreditAttribution: taz88ny commented
Status: Needs work » Needs review
netaustin’s picture

netaustin CreditAttribution: netaustin commented
  1. The else { should be on its own line.
  2. I'm thinking you should use module_exists() rather than db_table_exists()

Otherwise, looks clean and the logic seems right.

netaustin’s picture

netaustin CreditAttribution: netaustin commented
Status: Needs review » Needs work
taz88ny’s picture

taz88ny CreditAttribution: taz88ny commented
FileSize
issue_427296_v3.patch1.88 KB
taz88ny’s picture

taz88ny CreditAttribution: taz88ny commented
Status: Needs work » Needs review

Applied changes recommended by netaustin.

sharda_ram’s picture

sharda_ram CreditAttribution: sharda_ram commented

subscribe

Damien Tournoud’s picture

Damien Tournoud CreditAttribution: Damien Tournoud commented
Title: When all modules are disabled & uninstalled, the menu: admin/settings/performance encountered an error » Move some code of system_performance_settings() to the block module
Status: Needs review » Needs work

All the code of system_performance_settings() that relates to the block module should be moved to the block module. More precisely: the block module should implement hook_form_system_performance_settings_alter(), and insert its own code inside the form.

taz88ny’s picture

taz88ny CreditAttribution: taz88ny commented

I've applied the changes recommended by Damien Tournoud. The resulting description for the "caching mode" form on the "admin/settings/performance" page will be slightly different. What was once the second paragraph will now be the third. Let me know if this will be an issue.

taz88ny’s picture

taz88ny CreditAttribution: taz88ny commented
FileSize
issue_427296_v4.patch2.86 KB
taz88ny’s picture

taz88ny CreditAttribution: taz88ny commented
Status: Needs work » Needs review
kresimir’s picture

kresimir CreditAttribution: kresimir commented

subscribe

Damien Tournoud’s picture

Damien Tournoud CreditAttribution: Damien Tournoud commented
Status: Needs review » Reviewed & tested by the community

It was as simple as that! Perfect, thanks taz88ny!

Dries’s picture

Dries CreditAttribution: Dries commented
Status: Reviewed & tested by the community » Fixed

Committed to CVS HEAD. Yah. Thanks.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.