I need to add attributes to my tag, like class, id or custom ones

the current Form API does not allow that, so I did a small change to form_select_options function

this is my first pach, so forgive me if I screw something :)

CommentFileSizeAuthor
#24 414562.patch679 bytesattiks
#22 414562.patch684 bytesattiks
#20 414562-add-attributes-for-options.patch697 bytesattiks
#19 414562-add-attributes-for-options.patch697 bytesattiks
#17 414562-add-attributes-for-options.patch701 bytesattiks
#15 form.patch818 bytesafeijo
#14 form.patch619 bytesafeijo
#13 form.patch622 bytesafeijo
#8 form.patch1.88 KBafeijo
#7 form.patch1.83 KBafeijo
#3 form.patch1.44 KBafeijo
#1 form.patch1.31 KBafeijo
form.patch750 bytesafeijo
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

afeijo’s picture

afeijo
Primary language Portuguese, Brazil
Location Porto Alegre
CreditAttribution: afeijo commented
FileSize
form.patch1.31 KB

After rich debate with michaelfavia and Berdir, here is a new patch with the code more drupal style, using #options and element_children()

thanks guys

Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir commented
Status: Needs review » Needs work

- Another minor point, always use curly braces, even for single line statements.
- I think you need to pass only the "real" childrens through, call it like: form_select_options($element, element_children($choice));

afeijo’s picture

afeijo
Primary language Portuguese, Brazil
Location Porto Alegre
CreditAttribution: afeijo commented
FileSize
form.patch1.44 KB

changes done :)

afeijo’s picture

afeijo
Primary language Portuguese, Brazil
Location Porto Alegre
CreditAttribution: afeijo commented
Status: Needs work » Patch (to be ported)
afeijo’s picture

afeijo
Primary language Portuguese, Brazil
Location Porto Alegre
CreditAttribution: afeijo commented
Status: Patch (to be ported) » Needs review

to use it its simple

instead of:

'#options' => array('text 1', 'text 2');

use like this:

'#options' => array(
array('#value' => 'text 1', '#attributes' => array('class' => 'c1', )),
array('#value' => 'text 1', '#attributes' => array('class' => 'c2', )),
);

michaelfavia’s picture

michaelfavia CreditAttribution: michaelfavia commented

While i think this is an improvement over the first patch (still need to be roled against the project and not against the file alone), I would prefer to see "options" promoted to first class elements in FAPI instead (like checkbox is).

We could combine alot of the shared logic for form processing and display. The only impediment mentioned by Berdir and the only ones i foresee are that options cant be used alone (we could automatically provide a select with just one option in this case if wed like) and that options have OPTGTOUPS for structured arrays. But i think we could handle this fairly easily.

afeijo’s picture

afeijo
Primary language Portuguese, Brazil
Location Porto Alegre
CreditAttribution: afeijo commented
FileSize
form.patch1.83 KB

I found a conflict with that change and the FAPI protection

here is the new patch

afeijo’s picture

afeijo
Primary language Portuguese, Brazil
Location Porto Alegre
CreditAttribution: afeijo commented
FileSize
form.patch1.88 KB

now with the right path so the bot wont scream

Status: Needs review » Needs work

The last submitted patch failed testing.

sun’s picture

sun
Primary language German
Location Karlsruhe
CreditAttribution: sun commented
Title: How to add custom attributes to a <select> <option> tag? » Allow to add custom attributes to a <select> <option> tag

subscribing

chx’s picture

chx CreditAttribution: chx commented

dont mess with #options, use an #options_attributes instead.

afeijo’s picture

afeijo
Primary language Portuguese, Brazil
Location Porto Alegre
CreditAttribution: afeijo commented

That was my initial approach

I will do the appropriate changes and post a new patch today

thanks guru

afeijo’s picture

afeijo
Primary language Portuguese, Brazil
Location Porto Alegre
CreditAttribution: afeijo commented
Status: Needs work » Needs review
FileSize
form.patch622 bytes

Here it is, much simpler, just 3 lines change

afeijo’s picture

afeijo
Primary language Portuguese, Brazil
Location Porto Alegre
CreditAttribution: afeijo commented
FileSize
form.patch619 bytes

it had a debug char, removed.

afeijo’s picture

afeijo
Primary language Portuguese, Brazil
Location Porto Alegre
CreditAttribution: afeijo commented
FileSize
form.patch818 bytes

fixed cvs head
(I'm such a cvs noob, sorry)

Status: Needs review » Needs work

The last submitted patch failed testing.

attiks’s picture

attiks CreditAttribution: attiks commented
Status: Needs work » Needs review
FileSize
414562-add-attributes-for-options.patch701 bytes

new patch against head

Status: Needs review » Needs work

The last submitted patch, 414562-add-attributes-for-options.patch, failed testing.

attiks’s picture

attiks CreditAttribution: attiks commented
FileSize
414562-add-attributes-for-options.patch697 bytes

try again

attiks’s picture

attiks CreditAttribution: attiks commented
Status: Needs work » Needs review
FileSize
414562-add-attributes-for-options.patch697 bytes

grrr

Status: Needs review » Needs work

The last submitted patch, 414562-add-attributes-for-options.patch, failed testing.

attiks’s picture

attiks CreditAttribution: attiks commented
Status: Needs work » Needs review
FileSize
414562.patch684 bytes

final try ;p

Status: Needs review » Needs work

The last submitted patch, 414562.patch, failed testing.

attiks’s picture

attiks CreditAttribution: attiks commented
Status: Needs work » Needs review
FileSize
414562.patch679 bytes

again :/

Status: Needs review » Needs work

The last submitted patch, 414562.patch, failed testing.

casey’s picture

casey CreditAttribution: casey commented

Crosslinking:
#284917: Allow FAPI select, radios, and checkboxes to specify some options as disabled
#342316: Introduce proper Form API #types for 'option' and 'optgroup', and make #options consistent.

casey’s picture

casey CreditAttribution: casey commented
Version: 7.x-dev » 8.x-dev
sun’s picture

sun
Primary language German
Location Karlsruhe
CreditAttribution: sun commented
Status: Needs work » Closed (duplicate)

Proper architectural discussion and work happens in #342316: Introduce proper Form API #types for 'option' and 'optgroup', and make #options consistent.