Closed (fixed)
Project:
Drupal core
Version:
7.x-dev
Component:
block.module
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
25 Mar 2009 at 12:46 UTC
Updated:
13 Apr 2015 at 21:44 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
jody lynnComparing system_menu and block_menu shows that block_menu uses check_plain for $theme->info['name'] and system_menu does not. Check_plain should not be used for menu item titles, and in fact block_menu is the only core module that is doing this.
Comment #2
daniel korteThe help link for "Demonstrate block regions (THEME)" is also double escaped. I re-rolled the patch to include that instance.
Comment #3
balagan commentedI have run into this issue too. I confirm that applying the patch fixes it.
A screenshot after applying the patch, and one for the demonstration page.
Comment #4
balagan commentedComment #6
balagan commentedComment #8
balagan commentedTest succeeds, so back to RTBC as before.
Comment #11
dcam commentedComment #12
David_Rothstein commentedLooks good. I should have committed this earlier in the release cycle due to the string change, but I missed that this patch contained one. Going to commit it anyway since the string change is very minor and very-admin-facing; the impact on translations should be minimal.
Also looks like none of this is needed in Drupal 8 due to the double-escaping prevention Drupal 8 has elsewhere.
Committed to 7.x - thanks!