Make OG breadcrumbs disableable

breadcrumbs are so pitiful in D6 I hardly feel like fixing this. And D7 is looking the same unless someone leads the charge. I would take a patch for this if it shows up.

Is this something that Custom Breadcrumbs could take on?
It already works neatly with og posts (nodes only), by providing tokens for the og name, url etc.
There are discussions here about how to fix it for views: http://drupal.org/node/215475

I second this request to be able to disable OG breadcrumbs... they currently override my Menu Breadcrumbs - which is not what I want. I also don't want to have to hack OG module to 'turn off' this feature. Please please ad it as an option in the admin area.

Gold points if you can make it only use OG Breadcrumb when a Menu or Taxonomy breadcrumb does not exist... ;-)

I also second the request to be able to disable OG breadcrumbs.

Agreed, they should be optional.

subscribing

Agreed, OG breadcrumbs are unhelpful. You should be able to turn them off!

Here are two patches for OG 6.x-2

one adds a radio buttons for controlling breadcrumbs.
(in og/includes/og.admin.inc)

the other checks that setting and does or doesn't override drupals normal breadcrumbs
(in og/og.module)

rather simple really, and IMO an option that should be rolled in OG. The OG breadcrumbs just get in the way if you're expecting to use Menu Breadcrumbs or the Navigation menu as breadcrumbs.

Please let me know if there is any difficulties with my patches, I know PHP but haven't done a lot of group development.

How do we move towards committing this to OG?

Updating status... Think this should be considered seriously by OG powers that be. Can "assign" to me if further work is needed, but I think this is a full implementation of the requested feature.

Preliminary testing looks good, thanks a lot for this!

I'll update if I see any undesired behaviour.

If you don't want to hack OG, you can override this in the theme layer by adding the following to your template.php file:

function THEME_breadcrumb($breadcrumb) {  
  $breadcrumb = menu_get_active_breadcrumb();
  if (!empty($breadcrumb)) {
    return '<div class="breadcrumb">'. implode(' » ', $breadcrumb) .'</div>';
  }
}

This will override the breadcrumb that is passed into the theme function and use drupal menu system's breadcrumb instead.

yes, but philosophically it seems silly to have OG overwrite Drupals breadcrumbs only to have your template write drupals breadcrumbs back in when you could just cut it back a step by not having OG carry out that behavior (since it's apparently sub-ideal for so many people)

I'm not sure exactly what to set the status to, but it would be great if we could get some sort of reply from one of the project maintainers. A lot of people seconded the request for this feature and it seems to be a tiny and sensible change.

Looks good. Could you please change all these drupal_set_breadcrumb() calls to og_set_breadcrumb() calls and then put this check in one place.

Please see diff and patch page for instructions on creating a patch. One patch can span multiple files. If you just can't get that working, attach two patch files to the issue instead of one zip file. This makes it easier to review.

Also, if (variable_get('', 0)) is enough. Not need for the == 0 part.

Thanks for the patch.

Excellent tips! I'm sort of new to patching, so I hope this worked. I assume it is most appropriate to patch the DEV version, but since I started on the stable (or someone might want to use it) I've included that too.

Since I'm not 100% sure that I did a "multiple file patch" correctly, let me know if you have trouble with it. I can provide separate patches.

also with the variable_get, i changed to if(!variable_get(",0)) since I want to act on the state of 0 and not 1 (which PHP assumes 1 is true and 0 is false).

Thanks, Eric

Seems to work as expected, I have tried patching both the dev and stable one. Thanks a lot, this is exactly how it should work. This should go into OG Core ;-)

thanks for testing datune...

is this the correct status to get a maintainers attention again?

Subscribing

changed version status as there was a dev patch dated October 2nd.

+1
Thanks for the patch. I hope the maintainers fix this soon.

+++ includes/og.admin.inc	2009-10-02 12:17:55.000000000 -0700
@@ -87,6 +87,17 @@ function og_admin_settings() {
+    $options = array(t('Organic Groups Breadcrumbs'), t('Drupal Breadcrumbs'));

Only first letter should be capital.
Also there an extra space there.

+++ includes/og.admin.inc	2009-10-02 12:17:55.000000000 -0700
@@ -87,6 +87,17 @@ function og_admin_settings() {
+  unset($options);

Do we really need to unset the options?

+++ og.module	2009-10-02 12:14:06.000000000 -0700
@@ -1166,6 +1166,14 @@ function og_get_breadcrumb($group_node) 
+// Check whether to return OG or Drupal breadcrumbs

Please add PHPDocs in the form of

  /**
   * Check ...
   * @param
   * @return
   */ 

+++ og.module	2009-10-02 12:14:06.000000000 -0700
@@ -1166,6 +1166,14 @@ function og_get_breadcrumb($group_node) 
+	if (!variable_get('og_breadcrumbs',0)){
+		drupal_set_breadcrumb($bc);
+	}

Please fix tabs

Also it would be nice to have a simpletest to check the breadcrumbs option.

I'm on crack. Are you, too?

I see. I didn't know anything about coding standards then, and I've cleaned up some of the mess.

Also it struck me there was an even more efficient way to handle this. Instead of adding another function and multiple calls to it, I have merely included the logic in the exisiting og_get_breadcrumbs function instead.

I've incuded a stable and dev version of the patch

+++ og.new/includes/og.admin.inc	2010-04-20 17:15:39.000000000 -0700
@@ -87,6 +87,16 @@ function og_admin_settings() {
+  // og or drupal breadcrumbs setting  ¶

Words should start with a Capital letter. In this case it should be OG or Drupal ... Line should add it a dot. Also you have empty spaces all over, please remove them.

+++ og.new/includes/og.admin.inc	2010-04-20 17:15:39.000000000 -0700
@@ -87,6 +87,16 @@ function og_admin_settings() {
+    '#description' => t('Choose to use Organic Groups breadcrumbs or revert to  breadcrumbs drupal (or your other modules) provide.')

I think the description should be something like "Use Organic groups custom breadcrumbs."

+++ og.new/og.module	2010-04-20 17:36:32.000000000 -0700
@@ -1249,12 +1249,16 @@ function og_update_group($node) {
+  } else {

Should be:
}
else {

btw, you need to roll only against DEV. Thank you for the work...

Powered by Dreditor.

this looks promising indeed, please do keep going... would love to see in dev soon!
thank you

subscribe

subscribe

Anticipating this one as well myself. OG's a module I don't really want to break on upgrades so I'll just use the theme layer workaround for now...

This is my patch against 2.x-dev

As no review received: my patch adds the ability to configure the OG Breadcrumb visibility: you can choose to turn them off or not (default: on).
Patch also includes the uninstall cleanup for the setting.

great thanks

@thePanz,
Thanks for the patch, but please don't chane the status to RTBC on your own patch. Haven't got much time to review it before OG7 is out, but maybe others will.

@Amitaibu: sorry for that! I didn't mean to change the issue status, but add more details about my patch.
Regards

In case you all need this, here is a patch against 2.1 of the module. I hope this helps all those out there, with the same issue, as much as it did for me.

Thanks thePanz!

In case you all need this, here is a patch against 2.1 of the module. I hope this helps all those out there, with the same issue, as much as it did for me.

Thanks thePanz!

I've forked Amitaibu OG module from github and I've merged 2.x branch with this patch on commit https://github.com/thePanz/og/commit/86787a87697259bae5b5138f5437171016c...

Amitaibu : you can merge my edits with the default OG code (or cherry-pick the right code commit)

I've just run into a problem with the patch in #22. This is quite an edge case but if it happens that the user has selected for og not to set breadcrumbs, in og_get_breadcrumb you have not said to return anything it's just drupal_get_breadcrumb(). This falls down when og_view_group calls that breadcrumb function and does an array_pop on it. You get the error

warning: array_pop() [function.array-pop]: The argument should be an array in .../modules/contrib/og/og.module on line 967.

This patch fixes that, and also removes the t() functions from inside the l() which do not need to be there (Check the API page for l). There's also a couple of minor layout changes.

And here's the same patch for 6.x-2.1

Would love to see this in a new version of OG.

@Zombienaute, Thanks. Your patch worked for me.

This is a great feature. Hopefully they will get this into 2.2 if we ever get it.

l() does indeed need t().

OG support for both branches is in the pipeline for Crumbs.
This does include disabling some of the og-based breadcrumb logic.

I need some help from og experts to review the recent work:
#1819300: Support both branches of Organic Groups: 7.x-1.x and 7.x-2.x

@donquixote, this issue is OG6-specific. Not likely to find many OG7 folks wandering up and down these shadowed halls.

This version of Drupal is not supported anymore. If this is still an issue in the 8.x-1.x branch, please open a new up-to-date ticket. Closing.