the menu module test file wrongly refers to 'menu item' parameters that are objects. Seems like a lot of left-over D5 cruft.

This test deals with menu links that are arrays.

Simple find/replace re-naming, plus one minor refactoring. note - marking this minor refactoring is needed to write a test for: http://drupal.org/node/403526

CommentFileSizeAuthor
#3 menu-test-cleanup-403542-3.patch16.4 KBpwolanin
#2 menu-test-cleanup-403542-2.patch16.58 KBpwolanin
#1 menu-test-cleanup-403542-1.patch16.94 KBpwolanin
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

pwolanin’s picture

pwolanin CreditAttribution: pwolanin commented
FileSize
menu-test-cleanup-403542-1.patch16.94 KB
pwolanin’s picture

pwolanin CreditAttribution: pwolanin commented
Title: Clean up medu module test terminology » Clean up menu module test terminology
FileSize
menu-test-cleanup-403542-2.patch16.58 KB

whoops - missed a ; and never mind about the minor refactoring - keeping this to a simple rename.

pwolanin’s picture

pwolanin CreditAttribution: pwolanin commented
FileSize
menu-test-cleanup-403542-3.patch16.4 KB

changed 1 string too many - plus rm some comment cruft.

Damien Tournoud’s picture

Damien Tournoud CreditAttribution: Damien Tournoud commented
Status: Active » Needs review

Looks good, let's see what the test bot think.

pwolanin’s picture

pwolanin CreditAttribution: pwolanin commented
Status: Needs review » Reviewed & tested by the community

no functional changes, nothing breaks.

Damien Tournoud’s picture

Damien Tournoud CreditAttribution: Damien Tournoud commented

Good for me.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick commented
Status: Reviewed & tested by the community » Fixed

Committed, thanks!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.