adapt field's 'add-more' JS handler to recent FAPI changes, + test [#402264]

Didn't actually check, but #322344: (notice) Form improvements from Views most probably broke JS 'add more' button (no more $form['#post'])

Work is under way to refactor this area in #367567: Use AJAX framework for "Add more" / load include file containing form / introduce $form_state['build_info'], but we need to unbreak the current implementation first. No time for this tonight :-)

Comment	File	Size	Author
#4	field_fix_add_more-402264-5.patch	6.86 KB	yched
#4
#2	field_fix_add_more-402264-3.patch	6.41 KB	yched
#2
#1	field_fix_add_more-402264-2.patch	1.44 KB	yched
#1

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

yched CreditAttribution: yched commented 16 March 2009 at 20:35

Status:

Active

» Needs review

File	Size
field_fix_add_more-402264-2.patch	1.44 KB

Here's a hotfix patch. As I wrote above, this area needs serious refactoring, but we need to fix the current code first, at least to have something to compare against.

Comment #2

yched CreditAttribution: yched commented 16 March 2009 at 21:59

Title:

adapt field's 'add-more' JS handler to recent FAPI changes

» adapt field's 'add-more' JS handler to recent FAPI changes, + test

File	Size
field_fix_add_more-402264-3.patch	6.41 KB

Also : If we had a test for the AHAH-'add more' button, which I've been willing to write for some time now, then it would have been the job of the offending patch to fix this :-p.
So, same fix as above, with a test for the AHAH behavior. It will also be useful to validate #367567: Use AJAX framework for "Add more" / load include file containing form / introduce $form_state['build_info'],

The test steals the code poll.test uses to test its own 'add more' button, and abstracts it to a separate _fieldPostAhah() method.
Not sure whether it's worth promoting to DrupalWebTestCase, I leave that out to more FAPI / test oriented people to decide - in a separate thread ?

The test also updates the regexp used in the existing 'non AHAH' test to a more specific one, to make it match the AHAH test.

Comment #3

KarenS CreditAttribution: KarenS commented 17 March 2009 at 12:42

I found one more instance of '#programmed' on line 188 of field.form.inc that needs to be changed to 'programmed' to match the new API. Other than that the patch works fine. The bot doesn't like my patches, so I haven't re-rolled it myself, but if someone could add that fix in it should be good to go.

Comment #4

yched CreditAttribution: yched commented 17 March 2009 at 14:06

File	Size
field_fix_add_more-402264-5.patch	6.86 KB

Right, New patch with that last '#programmed' bit fixed.
Setting to RTBC based on Karen's feedback.

Comment #5

yched CreditAttribution: yched commented 17 March 2009 at 14:07

Status:

Needs review

» Reviewed & tested by the community

'Setting to RTBC', he said.

Comment #6

cburschka

they

CreditAttribution: cburschka commented 28 April 2009 at 12:46

$pattern[$weight] = "<input [^>]*value=\"$value\" [^>]*";

I'm not sure, but this looks odd compared to other places where we do string concatenation. Shouldn't you do '<input [^>]*value="' . $value . '" [^>]*'?

However, this seems to still apply, and it's been sitting in the RTBC queue for a month, so I'm bumping it up.