Foreport of the parts of CCK's #360712: RTL CSS files that now live in core.
Takes care of the table headers and drag-n-drop handles in forms for multiple values.

CommentFileSizeAuthor
#12 field-rtl-v4.patch1.07 KBJeff Burnz
#10 field-rtl-v3.patch606 bytesJeff Burnz
#7 field-float-inline-field-items-label_v2.patch626 bytesJeff Burnz
#5 field-float-inline-field-items-label_v1.patch582 bytesJeff Burnz
field-rtl.patch1.39 KByched
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

KarenS’s picture

KarenS CreditAttribution: KarenS commented
Status: Needs review » Reviewed & tested by the community

I don't have a right to left setup to test this on, but it's really simple and is the same code used in D6 so it looks like a no-brainer :)

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick commented
Status: Reviewed & tested by the community » Fixed

Committed to HEAD. :) Thanks!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Jeff Burnz’s picture

Jeff Burnz CreditAttribution: Jeff Burnz commented
Status: Closed (fixed) » Needs work

Need to float: right; the inline field label and items:

.field-label-inline .field-label,
.field-label-inline .field-items {
  float: right;
}
Jeff Burnz’s picture

Jeff Burnz CreditAttribution: Jeff Burnz commented
Status: Needs work » Needs review
FileSize
field-float-inline-field-items-label_v1.patch582 bytes

And a patch.

Status: Needs review » Needs work

The last submitted patch, field-float-inline-field-items-label_v1.patch, failed testing.

Jeff Burnz’s picture

Jeff Burnz CreditAttribution: Jeff Burnz commented
FileSize
field-float-inline-field-items-label_v2.patch626 bytes

Hmmm, lets try that again.

Jeff Burnz’s picture

Jeff Burnz CreditAttribution: Jeff Burnz commented
Status: Needs work » Needs review

kick the bot.

Status: Needs review » Needs work

The last submitted patch, field-float-inline-field-items-label_v2.patch, failed testing.

Jeff Burnz’s picture

Jeff Burnz CreditAttribution: Jeff Burnz commented
Status: Needs work » Needs review
FileSize
field-rtl-v3.patch606 bytes

Seem to be having some config issues with Eclipse, just got a new system so lets try this again, pretty sure this is line ending issue for me... grrr.

yched’s picture

yched CreditAttribution: yched commented
Status: Needs review » Needs work

Sounds reasonable.

However, I think it's standard practice to mark the corresponding LTR property with /* LTR */ in the original css file. See book.css and book-rtl.css

Jeff Burnz’s picture

Jeff Burnz CreditAttribution: Jeff Burnz commented
Status: Needs work » Needs review
FileSize
field-rtl-v4.patch1.07 KB

Arrr yes of course, here we go.

yched’s picture

yched CreditAttribution: yched commented
Status: Needs review » Reviewed & tested by the community

Thanks !

Dries’s picture

Dries CreditAttribution: Dries commented
Status: Reviewed & tested by the community » Fixed

Committed to CVS HEAD. Thanks.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.