Hi toemaz,

I've looked over the port again. Here's the latest attempt against 5.x-1.1. I'm including a module version and patches as well, for quick review. I'm not sure what I'm missing, but no blocks show up anywhere :( I've looked over the changes for Drupal functions, and I think I got them. Somehow I'm missing something. The table seems to install fine. I'm not sure. Could you give it a quick look?

It is gotta be close, not sure why I'm not seeing any results...

Regards,

Marius

CommentFileSizeAuthor
#3 user_visits_adv-6.x-1.x.zip11.92 KBmariusooms
user_visits_adv_6_port.tar_.gz8.36 KBmariusooms
user_visits_adv_6_patches.tar_.gz1.71 KBmariusooms

Comments

mariusooms’s picture

mariusooms commented

The block 'Latest visitors' works fine. However the most important one, namely, the history block is a no show. The data in the table gets populated with the correct values. Somehow the theme function must be incorrect, or somewhere else the history is not being fetched properly.

I really don't know at this point.

Regards,

Marius

mariusooms’s picture

mariusooms commented

Ahhh...I think the module drupal 6 version from User Visits is slightly different., so a straight port for user_vistits_adv won't work? So the query must probably be adjusted. Could use some help verifying these findings.

Regards,

Marius

mariusooms’s picture

mariusooms commented
StatusFileSize
new user_visits_adv-6.x-1.x.zip11.92 KB

Small type in the theme function was to blame...sheesss...Drupal 6 port ready. Put through coder to clean up code as well.

Please commit this version to the 6 branch.

Thanks,

Marius

mariusooms’s picture

mariusooms commented
Title: Drupal 6 port needs work » Drupal 6 port ready
Status: Active » Reviewed & tested by the community
toemaz’s picture

toemaz commented
Status: Reviewed & tested by the community » Fixed

Committed on the 6 branch.
Thanks for the good work Marius.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.