Another module to convert.

CommentFileSizeAuthor
#1 394584.translation.dbtng_.patch4.47 KBBerdir
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir commented
Status: Active » Needs review
FileSize
394584.translation.dbtng_.patch4.47 KB

Nothing special here, just a few conversions...

Crell’s picture

Crell CreditAttribution: Crell commented

I may be misreading the patch, but doesn't the first block move the first update query out of the else {} clause? Looks good otherwise visually.

Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir commented

There are two different queries, one inside the else, one outside, the closing bracket is moved a bit down. *Should* be fine...

Crell’s picture

Crell CreditAttribution: Crell commented
Status: Needs review » Reviewed & tested by the community

Ah! So it is. I didn't see it there. :-) Looks good then. Rock on!

Dries’s picture

Dries CreditAttribution: Dries commented
Status: Reviewed & tested by the community » Fixed

Committed to CVS HEAD. Thanks!

Status: Fixed » Closed (fixed)
Issue tags: -DBTNG Conversion

Automatically closed -- issue fixed for 2 weeks with no activity.

Issue tags: +DBTNG Conversion

Restoring issue tags, see #2125755: System messages removed all issue tags during D7 upgrade.