Another non-small module.

CommentFileSizeAuthor
#11 394572.system.dbtng5_.patch25.98 KBberdir
#8 394572.system.dbtng4_.patch26.01 KBberdir
#6 394572.system.dbtng3_.patch27.41 KBberdir
#4 394572.system.dbtng2_.patch27.41 KBberdir
#1 394572.system.dbtng_.patch27.44 KBberdir

Comments

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
StatusFileSize
new 394572.system.dbtng_.patch27.44 KB

Another one.

No problematic stuff here...

Done:
- Converted system module and tests
- Converted hook examples
- Converted 7xxx update hooks

The latest part needs to be carefully reviewed I think, upgrading of a freshly installed D6 installation worked fine but there wasn't much data to convert (like permissions and so on).

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Active » Needs review

Argh...

Status: Needs review » Needs work

The last submitted patch failed testing.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs work » Needs review
StatusFileSize
new 394572.system.dbtng2_.patch27.41 KB

Fixed a few typos.

Status: Needs review » Needs work

The last submitted patch failed testing.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs work » Needs review
StatusFileSize
new 394572.system.dbtng3_.patch27.41 KB

I have no idea why the tests fail, they pass locally. Trying again.

Status: Needs review » Needs work

The last submitted patch failed testing.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs work » Needs review
StatusFileSize
new 394572.system.dbtng4_.patch26.01 KB

Another try, I have no idea why this fails. These tests pass locally, both in the admin gui and with run-tests.sh

dries’s picture

dries commented

Line wrap issue: + $perm_old = file_save_data(''); db_update('files')

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs review » Needs work
berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs work » Needs review
StatusFileSize
new 394572.system.dbtng5_.patch25.98 KB

Re-roll with line wraping issue fixed.

dries’s picture

dries commented
Status: Needs review » Fixed

Awesome job, Berdir. Committed to CVS HEAD. Thanks.

Status: Fixed » Closed (fixed)
Issue tags: -DBTNG Conversion

Automatically closed -- issue fixed for 2 weeks with no activity.

Issue tags: +DBTNG Conversion

Restoring issue tags, see #2125755: System messages removed all issue tags during D7 upgrade.