Hello,

Have you scheduled any backport development of this module to D5?

Thanks,

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

tobiass’s picture

subscribing

kingandy’s picture

The module I posted in #148 of the original thread was a backport of the Drupal 6.x patch to Drupal 5.x, using IMCE 5.x-1.2 and Wysiwyg API 5.x-1.0, which still appear to be the recommended releases. I don't know if there's any plans to add it to the imce_wysiwyg project though, nor do I have any idea if there will be issues with WAPI 2.x if and when it gets released.

(Actually looking at #380944: Documentation and code clean-up I think somebody may have thought it was a 6.x module, because the first few comments on that thread talk about having "mixed some D5 code in there". I thought I was pretty clear on my post, though, what with the bold and such.)

sun’s picture

Category: task » feature

All we need is a new patch against imce_wysiwyg CVS HEAD (or the latest development snapshot) that changes the code to make it work on D5.

PixelClever’s picture

I'm sorry guys, but at this point I am not going to be able to test or develop any code for Drupal 5. I've got way too much work on my plate right now and I don't use this on any D5 sites.

k4ml’s picture

I try the module in #2 and it work on my site - Drupal-5.16 + wysiwyg-5.x-1.1 + IMCE-5.x-1.2.

rj’s picture

Module in #2 works on my site with same settings as k4ml above. Thank you kingandy!

sinasalek’s picture

4 people have tested (including me) it and it works fine, please let us know if it needs anything else?

PS : Works fine on my site as well with the same settings as k4ml , Thanks kingandy!

sun’s picture

Status: Active » Needs review

Actually, I don't see why the 6.x module would not work in D5...? Did anyone actually test to just use the 6.x module?

pletcher’s picture

FileSize
1.24 KB

With minor modifications with will work with FCK on D5. The only change I found is 'imce_access' doesn't exist in D5. I've replaced it with a 'user_access('access imce');', which although not complete (profiles?) works well enough for me.

Patch attached.

sun’s picture

Status: Needs review » Fixed
FileSize
1.75 KB

Committed attached patch to new DRUPAL-5 branch. A development snapshot will be available within the next 12 hours.

sun’s picture

Version: 6.x-1.x-dev » 5.x-1.x-dev

In case I forget to update the releases on the project page: http://drupal.org/node/422614 is where the development snapshot will be available.

Please report back if it works, so we can create an official release.

bfr’s picture

Seems to be partly working, only problem that under operations there is only "delete" button, no way to send the image to tinymce.
The upload itself works. Do i have some permission problem maybe or what?

edit: i have set 777 on the u1 and imce directories but does not help.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

sethcohn’s picture

Category: feature » bug
Status: Closed (fixed) » Needs work

The error in #12 is a showstopper. Some debugging reveals that in imceStartBrowser(), using WYSIWYG with TinyMCE v3, imceVar['targetWin'] isn't being set, meaning that no add button will be shown because the code doesn't know what the parent window is supposed to be.

jamestombs’s picture

Trying this out on a dev server and have the same problem as #12 which is detrimental to the functionality of the module.

sethcohn’s picture

Assigned: Unassigned » sethcohn
Priority: Normal » Critical
Status: Needs work » Needs review
FileSize
841 bytes

Enclosed find a patch for this issue. Lemuel of CommonPlaces gets the credit for carefully reviewing all of the javascript and php in IMCE and imce_wyiswyg and figuring out the missing piece of the puzzle, which was a missing call to IMCE's imce_set_tinymce.js and also setting imceBrowserURL. (In D5 IMCE's hook_footer, a check looking for the old tinymce module fails due to using wysiwyg API instead, so it doesn't load these files. Patching the bridge module makes more sense than trying to get a patch for D5 IMCE accepted, since you'll still need the bridge module anyway for wysiwyg API.)

Additionally, the D5 backport had bad references to missing js files that existed only in the D6 version of IMCE. (D5 has no js directory unlike D6, nor either of those 2 files called)
So I removed those lines as well for this patch.

This has NOT been tested for FCK functionality (which shouldn't have changed, if it was working), since we normally don't use FCK, but perhaps someone who does use it can test and report.

You now get the 'add' button for images, and it looks well.

Can we get this committed ASAP to the D5 dev branch, and maybe a formal 1.0 release?

sethcohn’s picture

FYI, I just (finally) checked kingandy's original backport (see #2), which looks like it did very similar things originally. (Looks like FCK is done the same way, in fact, so adding similar code might be needed after all). Somewhere in the translation/porting/patching into the final committed version in dev, things got haywire. It happens... but credit where credit is due to kingandy.

traviss359’s picture

Status: Needs review » Reviewed & tested by the community

Patch works with Drupal 5.18 and FCKeditor 2.6.4 (and TinyMCE 3.2.2.1). This issue exists #331089: Enhance FCKeditor support, Patch for multiline support for the 5.x version but that is not a concern for this queue. Many thanks for the fix!

sun’s picture

Status: Reviewed & tested by the community » Fixed

Thanks for reporting, reviewing, and testing! Committed with slight modifications.

A new development snapshot will be available within the next 12 hours. This improvement will be available in the next official release.

It would be nice if some of you could report back in this issue whether the new dev snapshot works, so I can create the first official release for 5.x.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

TheRec’s picture

Status: Closed (fixed) » Active

Ok,

The 5.x-1.x-dev package is working fine for me, for links and images. I think you can make a stable for 5.x, but you should also mention that it will only work with the -dev (or CVS) version of IMCE module at the moment, because in the current IMCE 5.x-1.2 (latest stable), the hook_wysiwyg_plugin is still implemented and this will lead to a double declaration of imce_wysiwyg_plugin function (and cause a PHP Fatal Error of course), which by the way could be called imce_wysiwyg_wysiwyg_plugin inside imce_wysiwyg module, if we try to follow the [module_name]_[hook_function_name] nomenclature).
Also we could ask ufku if he'd be ready to push a new stable of IMCE, now that there would exist a new stable for imce_wysiwyg 5.x ?

codewatson’s picture

I had this problem as well, however i realized that i still had a patched version of imce-5.x-1.2, once i replaced it with the original release everything worked correctly. I'd check your imce module, you may still have a patched version like i had.

Drupal 5.18 - wysiwyg 5.x-2.0 - imce_wysiwyg 5.x-1.x-dev (2009-May-31) - imce 5.x-1.2

TheRec’s picture

It is true, my bad... then it is even more simple, thank you drwatson ;)

So, sun, I tested with the versions dwatson mentioned above and it works as expected for links and images. I think it is safe to say that the current 5.x-dev is as stable as the 6.x-dev and thus deserves also an official version.

sun’s picture

Status: Active » Closed (fixed)

Done.

TheRec’s picture

Great. Thanks for your work :)