Don't limit database name length to 45

I meant to put that in PHP, not quote tags, of course.

    $form['basic_options']['database'] = array(
      '#type' => 'textfield',
      '#title' => st('Database name'),
      '#default_value' => empty($database['database']) ? '' : $database['database'],
      '#size' => 45,
      '#maxlength' => 45,
      '#required' => TRUE,
      '#description' => st('The name of the database your @drupal data will be stored in. It must exist on your server before @drupal can be installed.', array('@drupal' => drupal_install_profile_name())),
    );

The user, password, host and port are likewise limited to 45. All of these limits are arbitrary, since they don't match the specifications (hostnames can be 255 characters, users 16 characters, ports up to 65536 and therefore 5 digits). Being arbitrary, the limits therefore are completely useless for input validation. As the variables are stored in a settings file, there are no database field lengths to watch out for either. I think this makes the limits redundant; please correct me if I missed something.

Therefore, this patch removes the limits defined by the database (which can vary based on the type) and replaces the limits defined by common standards, ie. the hostname to 255 and the port to 5.

The limits are also arbitrary in D6, but without the file paths of SQLite there is no way to exceed the arbitrary limits (the natural limits are smaller). So it's only a cosmetic change.

Nevertheless, here is a patch for D6.